Better about box#1
Open
pbergeron-adsk wants to merge 27 commits into
Open
Conversation
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
…files section Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
…mySoftwareFoundation#1008) ### CI - Moving CY2024 MacOS Intel build from macos-13 to macos-15 ### Linked issues n/a ### Summarize your change. Moving CY2024 MacOS Intel build from macos-13 to macos-15 ### Describe the reason for the change. macos-13 are getting removed. ### Describe what you have tested and on which operating system. CI ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…on#1009) ### Build Fix: Ensure python wheels are build with RV's python ### Summarize your change. When building wheels with python, CMake would use whichever Python version it found first, which was usually your system python. This poses a problem when its a different version that RV's python if there are any compiled libraries built (like with opentimelineio for example), since when you try to import the package it will look module built against the matching version of python. To fix this issue, we will pass the python executable path to pip so we built it with RV's python. We will also use `--no-cache-dir` to ensure we always built the package. Even if our python version does have a cached version available, we might be building it with different compilers or different versions of shared libraries, so let's not take that chance and just force pip to always build with RV's python. We will also use and `--force-reinstall` so we will always build OTIO when we build Python to ensure no underlying changes to RV's python make this issue reappear. ### Describe the reason for the change. Build fix ### Describe what you have tested and on which operating system. Reproduced the issue on Mac OS, and verified the fix ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. --------- Signed-off-by: Roger Nelson <roger.nelson@autodesk.com>
Signed-off-by: pbergeron-adsk <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
…be opened when clicking away from the window (AcademySoftwareFoundation#1003) ### SG-40769 - Multiple RVLinkLauncher unresponsive dialogue windows can be opened when clicking away from the window ### Linked issues n/a ### Summarize your change. Fixed multiple dialog windows appearing when opening rvlink URLs. Added logic to terminate other running RVLinkLauncher instances on startup and automatically close any existing dialog when a new rvlink URL is received. This ensures only one chooser dialog is visible at a time - new rvlink URLs close the previous dialog and display a fresh one with the new URL. ### Describe the reason for the change. When users clicked multiple rvlink URLs from a browser, each click would create a new modal dialog that stacked on top of previous ones. Only the topmost dialog remained interactive, leaving users unable to interact with or close the underlying dialogs. This occurred because: (1) command-line launches created separate process instances that didn't coordinate with each other, and (2) browser-launched URLs were sent as Apple Events to an already-running instance that was blocked in a modal loop. The fix improves user experience by ensuring rvlink URLs are processed one at a time with a single, responsive dialog window. ### Describe what you have tested and on which operating system. Affects MacOS only ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
) ### SG-41087 - Remove filterLiveReviewEvents ### Linked issues n/a ### Summarize your change. Remove filterLiveReviewEvents ### Describe the reason for the change. Remove filterLiveReviewEvents because the categories based filtering has been implemented. ### Describe what you have tested and on which operating system. MacOS ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…reFoundation#1015) ### Linked issues [SG-41334](https://jira.autodesk.com/browse/SG-41334) ### Summarize your change. Add "skipping QEventPoint" to the list of silences Qt warnings that are issued to the console. ### Describe the reason for the change. We sometimes (but rarely) see this warning from within Qt. It's harmless, but annoying, so silenced it. _**WARNING: skipping QEventPoint(id=1 ts=0 pos=0,0 scn=1465.03,909.258 gbl=1465.03,909.258 Released ellipse=(1x1 ∡ 0) vel=0,0 press=-1465.03,-909.258 last=-1465.03,-909.258 Δ 1465.03,909.258) : no target window**_ ### Describe what you have tested and on which operating system. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
Signed-off-by: Patrick Bergeron <patrick.bergeron@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
Summarize your change.
Describe the reason for the change.
Describe what you have tested and on which operating system.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.