Skip to content

Commit c6bb8a5

Browse files
authored
Simplify room filtering a bit
The lookup table seems a bit redundant
1 parent 09dcce9 commit c6bb8a5

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lib/parse.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,11 @@ module.exports = function parse(xml, rooms) {
1111
const baseUrl = $('conference base_url').text();
1212

1313
const filterRooms = rooms && rooms.length;
14-
const roomFilter = {};
15-
for (let roomName of rooms || []) {
16-
roomFilter[roomName] = true;
17-
}
1814

1915
const days = $('day').map((i, day) => {
2016
const $day = $(day);
2117
const events = $day.find('room').filter((i, room) => {
22-
return filterRooms ? $(room).attr('name') in roomFilter : true;
18+
return filterRooms ? rooms.indexOf($(room).attr('name')) !== -1 : true;
2319
}).find('event').map((i, event) => {
2420
const $event = $(event);
2521
const t = (selector) => $event.find(selector).text() || null;

0 commit comments

Comments
 (0)