Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat ERB templates don't handle Undef / False properly #262

Open
vollmerk opened this issue Jul 15, 2020 · 0 comments
Open

Filebeat ERB templates don't handle Undef / False properly #262

vollmerk opened this issue Jul 15, 2020 · 0 comments

Comments

@vollmerk
Copy link

ERB templates don't behave as expected with Undef using Puppet Server/Agent 6.x

$logstash = Undef
$elasticsearch = false
class { 'filebeat':
 outputs => {
   'logstash' => $logstash,
   'elasticsearch' => $elasticsearch,
 },
}

Results in an outputted Yaml file containing

output:
 logstash: !ruby/object:puppet::Pops::Types::PUndefType {}
 elasticsearch: false

Expected behavior would be

 output:

Cleanest solution would likely be switching to EPP, so there aren't weird typing issues between Puppet & Ruby. I can submit a pull request, if this is aggreable (it's a bit of work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant