Relations has() fixed

- Tests passing

Author: pdphilip

src/Relations/Traits/QueriesRelationships.php

@@ -27,13 +27,8 @@ trait QueriesRelationships
      *
      * @throws Exception
      */
-    public function has(
-        $relation,
-        $operator = '>=',
-        $count = 1,
-        $boolean = 'and',
-        ?Closure $callback = null
-    ): Builder|static {
+    public function has($relation, $operator = '>=', $count = 1, $boolean = 'and', ?Closure $callback = null): Builder|static
+    {
         if (is_string($relation)) {
             if (str_contains($relation, '.')) {
                 // @phpstan-ignore-next-line
@@ -79,13 +74,8 @@ protected function isAcrossConnections(Relation $relation): bool
      *
      * @throws Exception
      */
-    public function addHybridHas(
-        Relation $relation,
-        string $operator = '>=',
-        int $count = 1,
-        string $boolean = 'and',
-        ?Closure $callback = null
-    ): mixed {
+    public function addHybridHas(Relation $relation, string $operator = '>=', int $count = 1, string $boolean = 'and', ?Closure $callback = null): mixed
+    {
         $hasQuery = $relation->getQuery();
         if ($callback) {
             $hasQuery->callScope($callback);
@@ -102,14 +92,22 @@ public function addHybridHas(
             $relation instanceof MorphToMany => $relation->getInverse() ?
                 $this->handleMorphedByMany($hasQuery, $relation) :
                 $this->handleMorphToMany($hasQuery, $relation),
-            default => $hasQuery->pluck($this->getHasCompareKey($relation))
+            default => $this->handleDefaultForeignIdsLookup($hasQuery, $relation)
         };
 
         $relatedIds = $this->getConstrainedRelatedIds($relations, $operator, $count);
 
         return $this->whereIn($this->getRelatedConstraintKey($relation), $relatedIds, $boolean, $not);
     }
 
+    private function handleDefaultForeignIdsLookup($query, $relation)
+    {
+        $key = $this->getHasCompareKey($relation);
+        $query->whereNotNull($key);
+
+        return $query->pluck($key);
+    }
+
     /**
      * @param  Builder  $hasQuery
      * @param  Relation  $relation

tests/Models/Group.php

@@ -17,7 +17,7 @@ class Group extends Model
 
     protected static $unguarded = true;
 
-    public function users(): BelongsToMany
+    public function groupUsers(): BelongsToMany
     {
         return $this->belongsToMany(User::class, 'users', 'groups', 'users', 'id', 'id', 'users');
     }

tests/Models/User.php

@@ -89,7 +89,7 @@ public function clients()
         return $this->belongsToMany(Client::class);
     }
 
-    public function groups()
+    public function userGroups()
     {
         return $this->belongsToMany(Group::class, 'groups', 'users', 'groups', 'id', 'id', 'groups');
     }

tests/RelationsTest.php

@@ -321,22 +321,22 @@
 
 it('tests belongs to many custom', function () {
     $user = User::create(['name' => 'John Doe']);
-    $group = $user->groups()->create(['name' => 'Admins']);
+    $group = $user->userGroups()->create(['name' => 'Admins']);
 
-    // Refetch
+    // Re-fetch
     $user = User::find($user->id);
     $group = Group::find($group->id);
 
     // Check for custom relation attributes
     expect($group->getAttributes())->toHaveKey('users')
         ->and($user->getAttributes())->toHaveKey('groups')
-        ->and($user->groups->pluck('id')->toArray())->toContain($group->id)
-        ->and($group->users->pluck('id')->toArray())->toContain($user->id)
-        ->and($user->groups()->first()->id)->toBe($group->id)
-        ->and($group->users()->first()->id)->toBe($user->id);
+        ->and($user->userGroups->pluck('id')->toArray())->toContain($group->id)
+        ->and($group->groupUsers->pluck('id')->toArray())->toContain($user->id)
+        ->and($user->userGroups()->first()->id)->toBe($group->id)
+        ->and($group->groupUsers()->first()->id)->toBe($user->id);
 
     // Assert they are attached
-})->todo();
+});
 
 it('tests morph', function () {
     $user = User::create(['name' => 'John Doe']);
@@ -854,7 +854,7 @@
         $query->where('rating', '<', 5);
     })->get();
     expect($authors)->toHaveCount(1);
-})->todo();
+});
 
 it('tests has one has', function () {
     $user1 = User::create(['name' => 'John Doe']);
@@ -874,7 +874,7 @@
 
     $users = User::has('role', '!=', 0)->get();
     expect($users)->toHaveCount(2);
-})->todo();
+});
 
 it('tests nested keys', function () {
     $client = Client::create([