[Bug Report]: Quantum Crafter crashing and locking savefile after attempting to dupe smithing template variations

[YukkuriC]

Minecraft Version

1.20.1

Mod Version

1.3.2-1.20.1

Did you test the latest version?

Yes

Severity

Odd Results

NeoForge Version

47.4.3

Describe the Issue

The game crashes after I inserted several crafting patterns of various smithing templates into a quantum crafter; since the world saved just before the crash, each time I re-enter the savefile, it crashes again
the corresponding exceptions is:

Caused by: java.lang.NullPointerException: Cannot invoke "appeng.api.stacks.GenericStack.amount()" because "genInput" is null
	at TRANSFORMER/advanced_ae@1.3.2-1.20.1/net.pedroksl.advanced_ae.common.entities.QuantumCrafterEntity.performCraft(QuantumCrafterEntity.java:498)

Reproduction Steps

1. take out every existing templates out
2. write duping templates for them
3. put the crafting patterns into a quantum crafter, and configure their target amounts
4. put the smithing templates back and crash

Screenshots and Videos

No response

Additional Context

No response

Crash log

https://mclo.gs/Fbsa8lG

[YukkuriC]

after I manually patched the crashing line to force-return, I found that the only smithing template that was stopped was minecraft:snout_armor_trim_smithing_template, which uses blackstone from a processing pattern; not sure if this is relevant
and here's its inner config:

the blackstone processing isn't auto-starting, and I guess it's the crashing source

[pedroksl]

The quantum crafter does not request crafts for missing materials, so your blackstone would stay at 0, anyway. For that you might wanna use a requester, to keep a minimum amount in stock.

However, this shouldn't ever cause a null input, or a crash. I'll look into that.

[pedroksl]

I just tried using the same recipe, and the crash did not happen. Tried not having any blackstone in inventory to see if input.getPossibleInputs() would return a null value, but that also didn't happen. Then I tried saving the game and reloading to see if there was any issue with the crafter's tag when saving/loading, but no crash there either. Makes me wonder if there was any issue with the pattern encoding in your case. The possible inputs list should never contain null values, but it can if something edited the list, which AE2's API explicitly forbids. If there's anything else you did that could be relevant for me to test, I would be willing to. However, as I can't reproduce the issue, I'll just add a null check for when this edge case happens again, to avoid crashes.

[YukkuriC]

thx, I'll try to reproduce it if I can later _(:з」∠)_

---

edit: tried again putting a snout dupe pattern inside quantum crafter, and crashed; also in a new savefile in the same pack, but didn't reproduce it either, wierd
maybe I could dump the whole input array when the null exception triggers? not sure if this would provide some useful info

[YukkuriC]

https://mclo.gs/mFWdTns
used modified logic like this:

            for (var genInput : input.getPossibleInputs()) {
                if (genInput == null) {
                    HexFlow.INSTANCE.getLOGGER().error("inputs:{}", String.join(", ", Arrays.stream(input.getPossibleInputs()).map(Objects::toString).toList()));
                    throw new EmptyStackException();
                }

this time when I created a pattern duping task of spire template, nothing happened because there was not even 1 template before; and the game crashed the moment I put a first template inside the grid
btw, according to the log, the pattern input matches all of my storage, I'm not familiar with how AE2 works, but this doesn't look normal as the variable names suggests

[pedroksl]

btw, according to the log, the pattern input matches all of my storage

This is definitely not normal behavior. getPossibleInputs() is a function from AE2 patterns that matches valid inputs for a given ingredient. For instance, you could match all plank types, if substitutions are enabled, but only oak logs if not. It shouldn't ever return your full inventory, unless something went very wrong during the encoding process. How did you encode these recipes? Did you use the standard AE2 encoder?

[YukkuriC]

I might have some idea about this
the pattern itself should be normal encoded, but both kubejs and connector + hexconnect should have done heavy mixins on the Ingredient class, maybe this comes from one of them?
I'll check one of the issued patterns and reply with its nbt later when I enter game, thank you for ur explanations btw :3

[YukkuriC]

I might have some idea about this the pattern itself should be normal encoded, but both kubejs and connector + hexconnect should have done heavy mixins on the Ingredient class, maybe this comes from one of them? I'll check one of the issued patterns and reply with its nbt later when I enter game, thank you for ur explanations btw :3

its content look like this, and I can't tell the difference because I don't know what's "standard" _(:з」∠)_
Item.of('ae2:crafting_pattern', '{in:[{Count:1b,id:"minecraft:diamond"},{Count:1b,id:"minecraft:silence_armor_trim_smithing_template"},{Count:1b,id:"minecraft:diamond"},{Count:1b,id:"minecraft:diamond"},{Count:1b,id:"minecraft:cobbled_deepslate"},{Count:1b,id:"minecraft:diamond"},{Count:1b,id:"minecraft:diamond"},{Count:1b,id:"minecraft:diamond"},{Count:1b,id:"minecraft:diamond"}],out:{Count:2b,id:"minecraft:silence_armor_trim_smithing_template"},recipe:"minecraft:silence_armor_trim_smithing_template",substitute:0b,substituteFluids:1b}')

[pedroksl]

The pattern itself looks fine. At this point the ingredient class isn't involved anymore, and I can see that substitutions are turned off. This raises more questions than explain them, to be honest hahaha.

Seeing as I can't reproduce this issue in my dev setup, can you give me a modlist for your pack to see if that gives me any clues?
Also, have you tried running a simple modpack with just AAE and its dependencies?

[YukkuriC]

it was inside the logs at the moment this issue is raised:

list

• advanced_ae 1.3.2-1.20.1
  -- ae2addonlib 1.0.3-1.20.1
• advancedperipherals 0.7.46r
• ae2 15.4.10
• ae2omnicells 1.0.7
• aeinfinitybooster 1.20.1-1.0.0+51
• ali 1.6.4
• appleskin 2.5.1+mc1.20.1
• architectury 9.2.14
• ars_elemental ...
• ars_nouveau 4.12.7
• attributefix 21.0.4
• attributeslib 1.3.7
• balm 7.3.38
  -- kuma_api 20.1.12
• betteradvancements ...
• bindable_mana_pool 1.19.2-1.1.0
• bookshelf 20.2.13
• bosses_of_mass_destruction 1.1.2
• botania 1.20.1-450-FORGE
• botania_overpowered 1.20.1-1.11.1
• caelus 3.2.0+1.20.1
• cardinal_components 5.2.3
• cardinal_components_base 5.2.3
• cardinal_components_block 5.2.3
• cardinal_components_chunk 5.2.3
• cardinal_components_entity 5.2.3
• cardinal_components_item 5.2.3
• cardinal_components_level 5.2.3
• cardinal_components_scoreboard 5.2.3
• cardinal_components_world 5.2.3
• cataclysm 3.16
• cc_androids 1.3.0
• cerbons_api 1.1.0
• cloth_config 11.1.136
• clumps ...
• com_github_llamalad7_mixinextras 0.1.1
• computercraft 1.117.0
• connectorextras 1.11.2+1.20.1
  |-- amecsapi 1.5.3+mc1.20-pre1
  |-- connectorextras_architectury_bridge 1.11.2+1.20.1
  |-- connectorextras_emi_bridge 1.11.2+1.20.1
  |-- connectorextras_energy_bridge 1.11.2+1.20.1
  |-- connectorextras_geckolib_fabric_compat 1.11.2+1.20.1
  |-- connectorextras_jei_bridge 1.11.2+1.20.1
  |-- connectorextras_kubejs_bridge 1.11.2+1.20.1
  |-- connectorextras_modmenu_bridge 1.11.2+1.20.1
  -- modmenu 7.2.2
  |-- connectorextras_pehkui_bridge 1.11.2+1.20.1
  |-- connectorextras_rei_bridge 1.11.2+1.20.1
  |-- connectorextras_terrablender_bridge 1.11.2+1.20.1
  |-- forgeconfigapiport 8.0.0
  -- reach_entity_attributes 2.4.0
• connectormod 1.0.0-beta.47+1.20.1
• create 6.0.8
  |-- flywheel 1.0.5
  -- ponder 1.0.91
• create_collection_bundles 1.20.1-1.1.1
• createaddition 1.20.1-1.3.3
• createbetterfps 1.1.1
• createnuclear 1.3.1
• curios 5.14.1+1.20.1
• curios_media_holder 1.20.1-1.0
• curseofpandora 2.4.26
  -- pandora 0.1.10
• duckyperiphs 1.20.1-1.3.1
• dungeonnowloading 2.11
• eccentrictome 1.20.1-1.10.4
• embeddium 0.3.31+mc1.20.1
  -- rubidium 0.7.1
• enchdesc 17.1.20
• expatternprovider 1.20-1.4.10-forge
• explorerscompass 1.20.1-1.3.3-forge
• fabric_api 0.92.6+1.11.14+1.20.1
  |-- fabric_api_base 0.4.32+ef105b4977
  |-- fabric_api_lookup_api_v1 1.6.37+67f9824077
  |-- fabric_biome_api_v1 13.0.14+dc36698e77
  |-- fabric_block_api_v1 1.0.12+0e6cb7f777
  |-- fabric_block_view_api_v2 1.0.3+53347ba977
  |-- fabric_blockrenderlayer_v1 1.1.42+1d0da21e77
  |-- fabric_client_tags_api_v1 1.1.3+5d6761b877
  |-- fabric_command_api_v1 1.2.35+f71b366f77
  |-- fabric_command_api_v2 2.2.14+561530ec77
  |-- fabric_content_registries_v0 4.0.13+a670df1e77
  |-- fabric_convention_tags_v1 1.5.6+fa3d1c0177
  |-- fabric_data_attachment_api_v1 1.0.2+30ef839e77
  |-- fabric_data_generation_api_v1 12.3.7+369cb3a477
  |-- fabric_dimensions_v1 2.1.55+8005d10d77
  |-- fabric_entity_events_v1 1.6.1+4ca7515277
  |-- fabric_events_interaction_v0 0.6.5+0f26153f77
  |-- fabric_game_rule_api_v1 1.0.41+683d4da877
  |-- fabric_item_api_v1 2.1.29+4d0bbcfa77
  |-- fabric_item_group_api_v1 4.0.14+c9161c2d77
  |-- fabric_key_binding_api_v1 1.0.38+561530ec77
  |-- fabric_lifecycle_events_v1 2.2.23+afab492177
  |-- fabric_loot_api_v2 1.2.3+eb28f93e77
  |-- fabric_message_api_v1 5.1.10+52cc178c77
  |-- fabric_mining_level_api_v1 2.1.52+561530ec77
  |-- fabric_model_loading_api_v1 1.0.4+6274ab9d77
  |-- fabric_models_v0 0.4.3+7c3892a477
  |-- fabric_networking_api_v1 1.3.14+fb7c822677
  |-- fabric_object_builder_api_v1 11.1.5+f8c414ce77
  |-- fabric_particles_v1 1.1.3+78e1ecb877
  |-- fabric_recipe_api_v1 1.0.24+514a076577
  |-- fabric_registry_sync_v0 2.3.6+1c0ea72177
  |-- fabric_renderer_api_v1 3.2.2+cf68abbe77
  |-- fabric_renderer_indigo 1.5.3+b5b2da4177
  |-- fabric_rendering_data_attachment_v1 0.3.39+a6081afc77
  |-- fabric_rendering_fluids_v1 3.0.29+4ac5e37a77
  |-- fabric_rendering_v1 3.0.9+66e9a48f77
  |-- fabric_resource_conditions_api_v1 2.3.9+996d00b277
  |-- fabric_resource_loader_v0 0.11.12+4b4151c077
  |-- fabric_screen_api_v1 2.0.9+45a670a577
  |-- fabric_screen_handler_api_v1 1.3.33+561530ec77
  |-- fabric_sound_api_v1 1.0.14+4f23bd8477
  |-- fabric_transfer_api_v1 3.3.6+631c9cd677
  -- fabric_transitive_access_wideners_v1 4.3.2+1880499877
• fabric_language_kotlin 1.13.8kotlin.2.3.0
• ferritecore 6.0.1
• flerovium 1.2.16
• forge 47.4.3
• friendlygriefing 1.0.2
• geckolib 4.8.2
• glodium 1.20-1.5-forge
• goety ...
• goety_cataclysm 1.20-1.5.0
• goety_revelation 2.2.7
  |-- ending_library 1.3.1
  -- revelationfix 3.8
• guideme 20.1.14
• hex_ars_link 1.20.1-0.9.3
• hexal 0.3.1
• hexcassettes 2.0.0
• hexcasting 0.11.3
• hexcellular 1.1.0
• hexconnect 1.0.2
• hexdebug 0.8.0
  -- hexdebug_core 0.8.0
• hexflow 1.20.1-0.4
• hexical 2.0.0
• hexoverpowered 1.20.1-0.11.5
• hexparse 1.20.1-1.8.1
• hexpose 1.0.0
• hextweaks 5.3.3
• inline 1.20.1-1.2.2
• ioticblocks 1.0.2+1.20.1
• jade 11.13.2+forge
• jadeaddons 5.5.0+forge
• jecharacters 4.5.16
• jeed 1.20-2.2.5
• jei ...
• jeiintegration 10.0.0
• kotlinforforge 4.12.0
• kubejs 2001.6.5-build.16
• l2complements 2.5.11
  -- l2damagetracker 0.4.4
• l2hostility 2.5.14
  -- mob_weapon_api 0.2.3
• l2library 2.5.3
  |-- l2itemselector 0.1.9
  |-- l2screentracker 0.1.4
  -- l2tabs 0.3.3
• libx 1.20.1-5.0.14
• lionfishapi 2.4-Fix
• magichem 0.5.2-pre22
• maxhealthfix 12.0.3
• merequester 1.20.1-1.1.5
• minecraft 1.20.1
• mna 3.1.11
• mnaoverpowered 1.20.1-0.7.1
• modernfix 5.25.2+mc1.20.1
• moreiotas 0.1.1
• moremobvariants ...
• morphtool 1.7-38
• mousetweaks 2.25.1
• mythicbotany 1.20.1-4.0.4
• nckey 1.0.0
• nerb 0.4.1
• neruina 2.1.2
• octolib ...
• oculus 1.8.0
• org_jetbrains_kotlin_kotlin_reflect 2.3.0
• org_jetbrains_kotlin_kotlin_stdlib 2.3.0
• org_jetbrains_kotlin_kotlin_stdlib_jdk7 2.3.0
• org_jetbrains_kotlin_kotlin_stdlib_jdk8 2.3.0
• org_jetbrains_kotlinx_atomicfu_jvm 0.29.0
• org_jetbrains_kotlinx_kotlinx_coroutines_core_jvm 1.10.2
• org_jetbrains_kotlinx_kotlinx_coroutines_jdk8 1.10.2
• org_jetbrains_kotlinx_kotlinx_datetime_jvm 0.7.1
• org_jetbrains_kotlinx_kotlinx_io_bytestring_jvm 0.8.2
• org_jetbrains_kotlinx_kotlinx_io_core_jvm 0.8.2
• org_jetbrains_kotlinx_kotlinx_serialization_cbor_jvm 1.9.0
• org_jetbrains_kotlinx_kotlinx_serialization_core_jvm 1.9.0
• org_jetbrains_kotlinx_kotlinx_serialization_json_jvm 1.9.0
• overflowingbars 8.0.1
• patchouli 1.20.1-84.1-FORGE
• paucal 0.6.0+1.20.1-forge
• placebo 8.6.3
• player_animator 1.0.2-rc11.20
• pneumaticcraft 6.0.22+mc1.20.1
• powerful_dummy 20-0.0.6-beta
• probejs 6.0.0
• puzzleslib 8.1.33
  -- puzzlesaccessapi 20.1.1
• repurposed_structures 7.1.19+1.20.1-forge
• rhino 2001.2.3-build.10
• serialization_hooks 0.5.99999
• sfm 4.28.0
• sophisticatedbackpacks 3.24.20.1500
• sophisticatedcore 1.2.120.1401
• spark 1.10.53
• storagedrawers 12.14.3
• stylisheffects 8.0.2
• trashslot 15.1.3
• twilightforest 4.3.2508
• world_preview 1.3.1
• xaerominimap 25.3.5
  -- xaerolib 1.0.45
• xaeroworldmap 1.40.6
• xaerozoomout 1.1.0

after that I added some AE integrations in one of my addon, but didn't touch anything about pattern reading I believe
I'll check it later using a pure pack :3

---

btw, just thought there could be another related mod about this feature: ae2omnicells, which introduces a series of discs storing any AEKey, haven't seen their code tho _(:з」∠)_

[YukkuriC]

btw, since this issue is live, I'll post another small issue I met here:
certain item with id wireless_quantum_crafter_terminal doesn't exist yet, but is required in various tags like #curios:curio, making this tag corrupted and a general curios slot always hidden, if LMFT not installed
(actually I didn't notice this until told by LMFT :3

[pedroksl]

wireless_quantum_crafter_terminal exists, but only when AE2 Wireless Terminals is also installed. I can't see why this would corrupt a tag, by simply adding an item that may not exist in runtime. The addition of this item into the tag is also not done by my mod.

[YukkuriC]

it is, I think _(:з」∠)_
maybe wrapping this with a {optional:true} will be fine?