-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadTable
should accept a path
#70
Comments
This is a valid request. I would not like to make a breaking API change. We should create a new function that allows the change of the LXR hash table location. Perhaps even allow an environment variable to change the location so all applications will respect it? |
I would be open to an environment variable, e.g., |
Moving the location is reasonable, but we have already made docker containers and externals apps with the home path. I think adding an environment variable would be flexible. Any PR to do that would likely be accepted |
We can do an environment variable. Just so you're aware of what that will mean for a Windows service using LXRHash, the service may need to have the environment variable set in the registry. If that's the case, then any changes will require a reboot. (I've not yet tested whether the service can simply set the environment variable once it starts, as a hacky way of passing the variable.) https://docs.microsoft.com/en-us/windows/win32/services/service-startup |
The
ReadTable
function currently expects to write a large file to the user's home directory. This interface should change (or a new interface added) to allow for the specification of a different directory. This makes sense for several reasons:I'm happy to submit a PR if one is welcome.
The text was updated successfully, but these errors were encountered: