PSMDB-1860 Remove unnecessary build options

The patch removes the following build options:
- `--audit`,
- `--enable-fcbis`,
- `--enable-fipsmode`,
- `--enable-oidc`,
- `--full-featured`,
- `--hotbackup`,
- `--inmemory`.

Their respective features are included in the build unconditionally.

Also, the patch moves the list of the Percona-specific features from
Python to C++ source code.

Author: ktrushin

CONTRIBUTING.rst

@@ -243,19 +243,9 @@ Build Percona Server for MongoDB
 
 2. Build Percona Server for MongoDB from ``buildscripts/scons.py``
 
-   * Basic build
-
-     .. code:: bash
-
-        $ buildscripts/scons.py --disable-warnings-as-errors --release --ssl --opt=on -j$(nproc --all) --use-sasl-client --wiredtiger --audit --inmemory --hotbackup CPPPATH="${AWS_LIBS}/include" LIBPATH="${AWS_LIBS}/lib ${AWS_LIBS}/lib64" install-mongod install-mongos
-        
-
-   * Pro build
-
-     .. code:: bash
+   .. code:: bash
 
-        $ buildscripts/scons.py --disable-warnings-as-errors --release --ssl --opt=on -j$(nproc --all) --use-sasl-client --wiredtiger --audit --inmemory --hotbackup --full-featured CPPPATH="${AWS_LIBS}/include" LIBPATH="${AWS_LIBS}/lib ${AWS_LIBS}/lib64" install-mongod install-mongos
-        
+      $ buildscripts/scons.py --disable-warnings-as-errors --release --ssl --opt=on -j$(nproc --all) --use-sasl-client --wiredtiger CPPPATH="${AWS_LIBS}/include" LIBPATH="${AWS_LIBS}/lib ${AWS_LIBS}/lib64" install-mongod install-mongos
 
    This command builds core components of the database. Other available
    targets for the ``scons`` command are:

SConstruct

@@ -87,21 +87,11 @@ def get_option(name):
 
 
 def has_option(name):
-    # For now, we just enable all the optional Percona-specific features.
-    # Since none of the features are going to be disabled, we can later
-    # remove the respective build flags completely
-    if name == 'full-featured':
-        return True
-
     optval = GetOption(name)
     # Options with nargs=0 are true when their value is the empty tuple. Otherwise,
     # if the value is falsish (empty string, None, etc.), coerce to False.
     return True if optval == () else bool(optval)
 
-# Returns true if a given option is set or if the 'full-featured' option is set.
-def has_feature_option(name):
-    return has_option(name) or has_option('full-featured')
-
 def use_system_version_of_library(name):
     return has_option('use-system-all') or has_option('use-system-' + name)
 
@@ -276,52 +266,6 @@ add_option(
     type='choice',
 )
 
-add_option(
-    'inmemory',
-    choices=['on', 'off'],
-    const='on',
-    default='off',
-    help='Enable InMemory',
-    nargs='?',
-    type='choice',
-)
-
-add_option(
-    'audit',
-    help='Enable auditing',
-    nargs=0,
-)
-
-add_option(
-    'hotbackup',
-    help='Enable Hot Backup',
-    nargs=0,
-)
-
-add_option(
-    'enable-fipsmode',
-    help='Enable tls.FIPSMode configuration option',
-    nargs=0,
-)
-
-add_option(
-    'enable-fcbis',
-    help='Enable file copy-based initial sync',
-    nargs=0,
-)
-
-add_option(
-    'enable-oidc',
-    help='Enable OpenID Connect authentication support',
-    nargs=0,
-)
-
-add_option(
-    'full-featured',
-    help='Enable all optional features',
-    nargs=0,
-)
-
 add_option(
     'ocsp-stapling',
     choices=['on', 'off'],
@@ -2714,38 +2658,6 @@ def link_guard_libdeps_tag_expand(source, target, env, for_signature):
 env['LIBDEPS_TAG_EXPANSIONS'].append(link_guard_libdeps_tag_expand)
 
 
-# Since none of the features are going to be disabled, we can later
-# remove the build flags completely and move the feature list to a more
-# appropriate place.
-assert has_option('audit'), "audit must be enabled"
-assert has_feature_option('enable-fipsmode'), "FIPS must be enabled"
-assert has_feature_option('enable-fcbis'), "FCBIS must be enabled"
-assert has_feature_option('enable-oidc'), "OIDC must be enabled"
-
-env['PERCONA_FEATURES'] = [
-    'MemoryEngine',
-    'HotBackup',
-    'BackupCursorAggregationStage',
-    'BackupCursorExtendAggregationStage',
-    'AWSIAM',
-    'Kerberos',
-    'LDAP',
-    'OIDC',
-    'TDE',
-    'FIPSMode',
-    'FCBIS',
-    'Auditing',
-    'ProfilingRateLimit',
-    'LogRedaction',
-    'ngram'
-]
-
-env.Append( CPPDEFINES=[ 'PERCONA_AUDIT_ENABLED' ] )
-
-env.SetConfigHeaderDefine("PERCONA_FIPSMODE_ENABLED")
-env.SetConfigHeaderDefine("PERCONA_FCBIS_ENABLED")
-env.SetConfigHeaderDefine("PERCONA_OIDC_ENABLED")
-
 env.Tool('forceincludes')
 
 # ---- other build setup -----
@@ -3269,11 +3181,8 @@ if get_option('wiredtiger') == 'on':
         wiredtiger = True
         env.SetConfigHeaderDefine("MONGO_CONFIG_WIREDTIGER_ENABLED")
 
-inmemory = False
-if get_option('inmemory') == 'on':
-    inmemory = True
-    if not wiredtiger:
-        env.FatalError("InMemory engine requires WiredTiger to build")
+if not wiredtiger:
+    env.FatalError("InMemory engine requires WiredTiger to build")
 
 if get_option('ocsp-stapling') == 'on':
     # OCSP Stapling needs to be disabled on ubuntu 18.04 machines because when TLS 1.3 is
@@ -6386,9 +6295,7 @@ Export([
     'endian',
     'get_option',
     'has_option',
-    'has_feature_option',
     'http_client',
-    'inmemory',
     'jsEngine',
     'module_sconscripts',
     'optBuild',

docs/audit/README.md

@@ -1,19 +1,11 @@
 
 # Auditing
 
-This document describes how to build, enable, configure and test auditing in Percona Server for MongoDB.  
+This document describes how to enable, configure and test auditing in Percona Server for MongoDB.
 
 Auditing allows administrators to track and log user activity on a server.  With auditing enabled, the server 
 will generate an audit log file. This file contains information about different user events including authentication, authorization failures, and more.
 
-## Building
-
-By default, when building Percona Server for MongoDB from source, audit functionality is 
-neither compiled with, nor linked into, the final binary executable.  To enable auditing, execute
-SCons with the `--audit` argument:
-
-    scons <other options> --audit <targets>
-
 ## Activation and Configuration
 
 The following server parameters control auditing.  They are entered at the command line when starting a server instance.

docs/inmemory/README.md

@@ -1,20 +1,11 @@
 
 # InMemory engine
 
-This document describes how to build, enable, configure and test InMemory engine in Percona Server for MongoDB.
+This document describes how to enable, configure and test InMemory engine in Percona Server for MongoDB.
 
 InMemory engine is a special configuration of WiredTiger that doesn’t store user data on disk.
 With this engine, data fully resides in the virtual memory of the system.
 
-## Building
-
-To enable building InMemory engine, execute SCons with the `--inmemory` argument.
-WiredTiger engine is also required for building (use the `--wiredtiger` argument).
-
-```
-scons <other options> --inmemory --wiredtiger <targets>
-```
-
 ## Activation and Configuration
 
 To use InMemory engine, run mongod with `--storageEngine=inMemory` option.

percona-packaging/debian/rules

@@ -25,17 +25,15 @@ override_dh_auto_clean:
 	dh_auto_clean
 	rm -fr $(PSMSRC)/bin
 	#rm -fr $(INSTALLDIR)
-	buildscripts/scons.py CC=$(CC) CXX=$(CXX) -C $(PSMSRC) -c --disable-warnings-as-errors --audit --release --ssl --opt -j$(NJOBS) --use-sasl-client CPPPATH=$(INSTALLDIR)/include \
-	--full-featured \
-	LIBPATH=$(INSTALLDIR)/lib LINKFLAGS=$(OPT_LINKFLAGS) --wiredtiger --inmemory --hotbackup $(PSM_TARGETS) || exit $?
+	buildscripts/scons.py CC=$(CC) CXX=$(CXX) -C $(PSMSRC) -c --disable-warnings-as-errors --release --ssl --opt -j$(NJOBS) --use-sasl-client CPPPATH=$(INSTALLDIR)/include \
+	LIBPATH=$(INSTALLDIR)/lib LINKFLAGS=$(OPT_LINKFLAGS) --wiredtiger $(PSM_TARGETS) || exit $?
 	rm -fr build resmoke.ini
 	find $(PSMSRC) -name '*.pyc' -delete
 
 # Finally PSMDB
 percona-server-mongodb:
-	buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --audit --release --ssl --opt=on -j$(NJOBS) \
-	--full-featured \
-	--use-sasl-client --wiredtiger --inmemory --hotbackup \
+	buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --release --ssl --opt=on -j$(NJOBS) \
+	--use-sasl-client --wiredtiger \
 	CPPPATH=${INSTALLDIR}/include LIBPATH=${INSTALLDIR}/lib LINKFLAGS=${OPT_LINKFLAGS} ${PSM_TARGETS} || exit $?
 
 compile-mongo-tools:

percona-packaging/redhat/percona-server-mongodb.spec.template

@@ -178,10 +178,9 @@ mv ${INSTALLDIR_AWS}/lib*/* ${INSTALLDIR}/lib/
 
 # Build PSfMDB with SCons
 pushd $RPM_BUILD_DIR/%{src_dir}
-buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --audit --release --ssl --opt=on  \
+buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --release --ssl --opt=on  \
 %{?_smp_mflags} --use-sasl-client CPPPATH=${INSTALLDIR}/include LIBPATH="${INSTALLDIR}/lib ${AWS_LIBS}/lib ${AWS_LIBS}/lib64" \
---full-featured \
---wiredtiger --inmemory --hotbackup LINKFLAGS="${OPT_LINKFLAGS}" ${PSM_TARGETS} || exit $?
+--wiredtiger LINKFLAGS="${OPT_LINKFLAGS}" ${PSM_TARGETS} || exit $?
 rm -fr resmoke.ini
 popd
 

percona-packaging/scripts/psmdb_builder.sh

@@ -1021,10 +1021,10 @@ build_tarball(){
       export OPT_LINKFLAGS="${OPT_LINKFLAGS} ${CURL_LINKFLAGS}"
     fi
     if [ ${DEBUG} = 0 ]; then
-        buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --release --ssl --opt=on -j${NCPU} --use-sasl-client --full-featured --wiredtiger --audit --inmemory --hotbackup CPPPATH="${INSTALLDIR}/include ${AWS_LIBS}/include" LIBPATH="${INSTALLDIR}/lib ${AWS_LIBS}/lib ${AWS_LIBS}/lib64" LINKFLAGS="${OPT_LINKFLAGS}" ${PSM_REAL_TARGETS[@]} || exit $?
+        buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --release --ssl --opt=on -j${NCPU} --use-sasl-client --wiredtiger CPPPATH="${INSTALLDIR}/include ${AWS_LIBS}/include" LIBPATH="${INSTALLDIR}/lib ${AWS_LIBS}/lib ${AWS_LIBS}/lib64" LINKFLAGS="${OPT_LINKFLAGS}" ${PSM_REAL_TARGETS[@]} || exit $?
     else
-        buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --audit --ssl --dbg=on -j${NCPU} --use-sasl-client \
-        CPPPATH="${INSTALLDIR}/include ${AWS_LIBS}/include" LIBPATH="${INSTALLDIR}/lib ${AWS_LIBS}/lib ${AWS_LIBS}/lib64" LINKFLAGS="${OPT_LINKFLAGS}" --full-featured --wiredtiger --inmemory --hotbackup ${PSM_REAL_TARGETS[@]} || exit $?
+        buildscripts/scons.py CC=${CC} CXX=${CXX} --disable-warnings-as-errors --ssl --dbg=on -j${NCPU} --use-sasl-client \
+        CPPPATH="${INSTALLDIR}/include ${AWS_LIBS}/include" LIBPATH="${INSTALLDIR}/lib ${AWS_LIBS}/lib ${AWS_LIBS}/lib64" LINKFLAGS="${OPT_LINKFLAGS}" --wiredtiger ${PSM_REAL_TARGETS[@]} || exit $?
     fi
     #
     # scons install doesn't work - it installs the binaries not linked with fractal tree

src/mongo/SConscript

@@ -77,9 +77,6 @@ config_header_substs = (
     ('@mongo_config_wiredtiger_enabled@', 'MONGO_CONFIG_WIREDTIGER_ENABLED'),
     ('@mongo_config_grpc@', 'MONGO_CONFIG_GRPC'),
     ('@mongo_config_have_basic_stringbuf_str_rvalue@', 'MONGO_CONFIG_HAVE_BASIC_STRINGBUF_STR_RVALUE'),
-    ('@percona_fipsmode_enabled@', 'PERCONA_FIPSMODE_ENABLED'),
-    ('@percona_fcbis_enabled@', 'PERCONA_FCBIS_ENABLED'),
-    ('@percona_oidc_enabled@', 'PERCONA_OIDC_ENABLED'),
 )
 
 

src/mongo/config.h.in

@@ -107,17 +107,5 @@
 // Defined if grpc support is enabled
 @mongo_config_grpc@
 
-
-// Percona specific section
-
-// FIPSMode enabled
-@percona_fipsmode_enabled@
-
-// FCBIS enabled
-@percona_fcbis_enabled@
-
-// OIDC enabled
-@percona_oidc_enabled@
-
 // Defined if basic_stringbuf::str()&& overload exists
 @mongo_config_have_basic_stringbuf_str_rvalue@