Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Await Expression for Websocket Closing #36

Closed
wes8ty opened this issue May 8, 2024 · 3 comments
Closed

No Await Expression for Websocket Closing #36

wes8ty opened this issue May 8, 2024 · 3 comments
Assignees

Comments

@wes8ty
Copy link

wes8ty commented May 8, 2024

Was testing this library out and the following line self._websocket.close(code) needs an await

async def close(self, code: int = 1000):
    if self._websocket is not None:
        # Case opened, we have something to close.
        self._websocket.close(code)
@orweis
Copy link
Contributor

orweis commented May 9, 2024

Want to open a PR? :)

@mberdyshev
Copy link
Contributor

Should it be closed now by #43?

@orweis
Copy link
Contributor

orweis commented Dec 2, 2024

Yes you are correct - @mberdyshev - thank you.

Closed by #43

@orweis orweis closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants