Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory.SetAccessControl does not set InheritanceFlags and PropagationFlags #49

Open
afkos opened this issue Sep 30, 2016 · 2 comments
Assignees

Comments

@afkos
Copy link

afkos commented Sep 30, 2016

Directory.SetAccessControl does not set InheritanceFlags and PropagationFlags
Directory.CreateDirectory(string path, DirectorySecurity directorySecurity) has the same problem

test to reproduce:

var localAdmins = new SecurityIdentifier(WellKnownSidType.BuiltinAdministratorsSid, null);
security.AddAccessRule(new FileSystemAccessRule(localAdmins,
    FileSystemRights.FullControl,
    InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit,
    PropagationFlags.NoPropagateInherit,
    AccessControlType.Allow));

Pri.LongPath.Directory.CreateDirectory(path);
Pri.LongPath.Directory.SetAccessControl(path, security);
ShowDirectorySecurity(path);
// FileSystemRights=FullControl, InheritanceFlags=[None], PropagationFlags=[None], AccessControlType=Allow

Directory.Delete(path);

System.IO.Directory.CreateDirectory(path);
System.IO.Directory.SetAccessControl(path, security);
ShowDirectorySecurity(path);
// FileSystemRights=FullControl, InheritanceFlags=[ContainerInherit, ObjectInherit], PropagationFlags=[NoPropagateInherit], AccessControlType=Allow

Directory.Delete(path);
@peteraritchie
Copy link
Owner

Do you have a reference for ShowDirectorySecurity? I'd like to be able to reproduce the data it's getting as a series of asserts.

@afkos
Copy link
Author

afkos commented Oct 12, 2016

Unfortunately I have no reference for ShowDirectorySecurity for now
I wrote another test for this issue

private static FileSystemAccessRule GetFileSystemAccessRule(string path)
{
    return Directory.GetAccessControl(path).GetAccessRules(true, false, typeof(SecurityIdentifier)).OfType<FileSystemAccessRule>().Single();
}

[TestMethod]
public void TestDirectorySetAccessControl()
{
    var path = Path.Combine(Path.GetTempPath(), "TestDir");
    var security = new DirectorySecurity();

    var localAdmins = new SecurityIdentifier(WellKnownSidType.BuiltinAdministratorsSid, null);
    security.AddAccessRule(new FileSystemAccessRule(localAdmins,
        FileSystemRights.FullControl,
        InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit,
        PropagationFlags.NoPropagateInherit,
        AccessControlType.Allow));

    // System.IO.Directory.SetAccessControl works fine
    Assert.IsFalse(Directory.Exists(path));
    System.IO.Directory.CreateDirectory(path);
    try
    {
        System.IO.Directory.SetAccessControl(path, security);
        Assert.AreEqual(GetFileSystemAccessRule(path).InheritanceFlags, InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit);
        Assert.AreEqual(GetFileSystemAccessRule(path).PropagationFlags, PropagationFlags.NoPropagateInherit);
    }
    finally
    {
        Directory.Delete(path);
    }

    // Pri.LongPath.Directory.SetAccessControl fails
    Assert.IsFalse(Directory.Exists(path));
    Pri.LongPath.Directory.CreateDirectory(path);
    try
    {
        Pri.LongPath.Directory.SetAccessControl(path, security);
        Assert.AreEqual(GetFileSystemAccessRule(path).InheritanceFlags, InheritanceFlags.ContainerInherit | InheritanceFlags.ObjectInherit);
        Assert.AreEqual(GetFileSystemAccessRule(path).PropagationFlags, PropagationFlags.NoPropagateInherit);
    }
    finally
    {
        Directory.Delete(path);
    }
}

@peteraritchie peteraritchie self-assigned this Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants