Using OPTION for keyboard shortcuts breaks the ability to type certain characters for non-US keyboards

[ItalyPaleAle]

Please note that security bugs or issues should be reported to [email protected].

Describe the bug

I use a Mac with an Italian keyboard. In my keyboard, to type } I need to use the combination OPTION + SHIFT + +

However, when in the query editor, in pgAdmin4 9.0 that switches the tab from Query to Query History, so I am unable to type the } key. My only workaround is to type that somewhere else, then copy-paste.

Note that in macOS, the OPTION key is generally reserved for combinations that allow typing "special" characters. Keyboard shortcuts should use CMD as modifier.

To Reproduce

Steps to reproduce the behavior:

In the general case:

1. Use a Mac with non-US keyboard
2. Using the OPTION key as modifier should allow typing "special" characters. However, sometimes pgAdmin4 uses that for keyboard shortcuts

In the specific case:

1. Use a Mac with an Italian keyboard
2. Typing } in the query editor (OPTION + SHIFT + +) is not possible because it is mapped to a keyboard action.

Expected behavior

In order to support users with non-US keyboards, please do not use the OPTION key as modifier for keyboard shortcuts.

Error message

N/A

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: macOS (any)
• Version: 9.0
• Mode: Desktop

[adityatoshniwal]

Hi @ItalyPaleAle,

You can customise the shortcuts from preferences. Did you try?

[ItalyPaleAle]

@adityatoshniwal thanks, I have removed that keyboard shortcut.

My point however still stands, that on Mac the OPTION key is used in combinations to type "special" characters. Using that for keyboard shortcuts is very frustrating for users of non-ANSI keyboards (used pretty much everywhere outside of the US and Canada). IMHO, the defaults should work for users regardless of the locale of their software or hardware.

[adityatoshniwal]

@adityatoshniwal thanks, I have removed that keyboard shortcut.

My point however still stands, that on Mac the OPTION key is used in combinations to type "special" characters. Using that for keyboard shortcuts is very frustrating for users of non-ANSI keyboards (used pretty much everywhere outside of the US and Canada). IMHO, the defaults should work for users regardless of the locale of their software or hardware.

Hi,

pgAdmin can run in browser as well. So we have very limited options for shortcuts because there can be conflicts with default browser or OS shortcuts as well. The option key works like Alt on windows.
It is also possible that the pgAdmin server is running on linux machine but the client is using MacOS/Windows browser.
The current shortcuts covers maximum browser and OS versions.

Thanks.