From d2a7499f13a4bce10034d65fc182c104d9230ce2 Mon Sep 17 00:00:00 2001 From: Lukas Fittl Date: Thu, 20 Feb 2025 13:55:46 -0800 Subject: [PATCH] Use Ubuntu 22.04 for building/testing generated binaries We've previously used Ubuntu 20.04 for the x86_64 binary, to avoid building a too new glibc. Unfortunately with Ubuntu 20.04 GH actions on the way out, this seems to no longer work reliably. Separately, we were already building the arm64 packages with an undefined Ubuntu version (likely 24.04?). To fix, consistently use Ubuntu 22.04 (glibc 2.35) for both x86_64 and arm64. This also switches to GitHub's ARM runners from Ubicloud, since Ubicloud does not offer tagged Ubuntu versions in their runners. --- .github/workflows/release.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c2a6752e..a9f429eb 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -7,9 +7,7 @@ on: jobs: build: - # Use older Ubuntu release to avoid building with a too new glibc, which will cause - # errors on older distributions, if anyone uses the generated binary directly. - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 permissions: {} # ensure we don't release on create events for branches (only tags) if: ${{ startsWith( github.ref, 'refs/tags' ) }} @@ -46,7 +44,7 @@ jobs: path: pganalyze-collector-linux-amd64 build_arm: - runs-on: ubicloud-standard-2-arm + runs-on: ubuntu-22.04-arm permissions: {} # ensure we don't release on create events for branches (only tags) if: ${{ startsWith( github.ref, 'refs/tags' ) }} @@ -56,7 +54,7 @@ jobs: - name: Set up Go 1.x uses: actions/setup-go@v5 with: - go-version: 1.21 + go-version: 1.23 id: go - name: Set up protoc