Tweak explain_analyze helper invocation to avoid pg_hint_plan limitation #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the collector-based Query Tuning workflow, the collector receives a query text from the pganalyze server and runs it on the target database. This query text may include pg_hint_plan hints, as users use workbooks to optimize queries. However, it looks like pg_hint_plan ignores hints if they are not in the _first_ comment in a query. The collector prepends a query marker as a separate comment, and this causes pg_hint_plan to ignore any hints specified in the query. Avoid passing our query marker, since we're already prepending it to the top-level explain_analyze invocation, and nested queries will not show up in pg_stat_activity anyway.
msakrejda
deleted the
tweak-explain_analyze-helper-invocation-to-avoid-pg_hint_plan-limitation
branch
msakrejda
added a commit
that referenced
this pull request
Feb 20, 2025
msakrejda
added a commit
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the collector-based Query Tuning workflow, the collector receives
a query text from the pganalyze server and runs it on the target
database. This query text may include pg_hint_plan hints, as users use
workbooks to optimize queries.
However, it looks like pg_hint_plan ignores hints if they are not in
the first comment in a query. The collector prepends a query marker
as a separate comment, and this causes pg_hint_plan to ignore any
hints specified in the query.
Avoid passing our query marker, since we're already prepending it to
the top-level explain_analyze invocation, and nested queries will not
show up in pg_stat_activity anyway.