GH release action: Fix "packages" name conflict #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the release process we group together the created packages as an artifact, to then upload them individually to the GitHub release entry. Previously this was able to use a single "packages" zip file for both x86_64 and arm64 packages, but we now need to split this since we split the actions.
msakrejda
approved these changes
Feb 20, 2025
We've previously used Ubuntu 20.04 for the x86_64 binary, to avoid building a too new glibc. Unfortunately with Ubuntu 20.04 GH actions on the way out, this seems to no longer work reliably. Separately, we were already building the arm64 packages with an undefined Ubuntu version (likely 24.04?). To fix, consistently use Ubuntu 22.04 (glibc 2.35) for both x86_64 and arm64. This also switches to GitHub's ARM runners from Ubicloud, since Ubicloud does not offer tagged Ubuntu versions in their runners.
lfittl
commented
Feb 20, 2025
| @@ -56,7 +54,7 @@ jobs: | |||
| - name: Set up Go 1.x | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: 1.21 | |||
| go-version: 1.23 | |||
There was a problem hiding this comment.
Looks like this was missed in the Go version change by accident.
There was a problem hiding this comment.
ah good catch, thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the release process we group together the created packages as an artifact, to then upload them individually to the GitHub release entry.
Previously this was able to use a single "packages" zip file for both x86_64 and arm64 packages, but we now need to split this since we split the actions.