Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using {evaluate} in place of capture_expr_output #252

Open
dgkf opened this issue Jun 27, 2022 · 1 comment
Open

Consider using {evaluate} in place of capture_expr_output #252

dgkf opened this issue Jun 27, 2022 · 1 comment
Assignees

Comments

@dgkf
Copy link
Collaborator

dgkf commented Jun 27, 2022

I just recently discovered this evaluate package, which seems to aim to solve the same problem that capture_expr_output solves. Unlike capture_expr_output, evaluate has years of development behind it with contributions from many very well established folks in the R space.

I contributed capture_expr_output at a time when we were still experimenting with this ability to log metric evaluation and wasn't aware that there were better solutions out there. Although I'm reasonably satisfied with where the code ended up, it's always felt like it could be a problematic and complex bit of code to try to maintain. It might be worth swapping it out to have some reassurance that we can look for some help from some very talented folks to help support this feature.

@emilliman5 emilliman5 self-assigned this Jan 25, 2023
@emilliman5
Copy link
Collaborator

See #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants