Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop back from first to last entry when pressing Up #76

Open
adamnejm opened this issue Jan 10, 2023 · 1 comment
Open

Loop back from first to last entry when pressing Up #76

adamnejm opened this issue Jan 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@adamnejm
Copy link

Tofi already loops back to the first entry when pressing Down arrow while last entry is selected, but the same doesn't happen in reverse.

While not that useful in run or drun modes, it would be a really nice addition for custom menus that have a moderate amount of entries, eg. a logout menu with shutdown, logout, reboot, hibernate, etc.

I don't see it hurting usability being the de facto behavior, but having an option to enable / disable it would be totally fine as well.

@philj56 philj56 added the enhancement New feature or request label Jan 10, 2023
@philj56
Copy link
Owner

philj56 commented Jan 10, 2023

This actually used to be how it was done, and I think that's the "correct" behaviour. See my comment at #21 (comment) for why it's done the way it is now.

Basically, having pagination of results and the ability to jump to the last result in horizontal mode implies quite a lot of extra complexity, due to the varying width of results. In vertical mode, it's trivial, as every result is the same height.

Having said that, I feel that there might be some way to special-case jumping to the last result. I'll think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants