Deleted Attribute did not worked

[sonkt]

Hi @phnx47
I user [Deleted] Attribute in my Entity, but i see it did not generated to Update command.

**

**
Please tell me how to fix it.

[phnx47]

I believe that issue that you use new modifier. Try with any property without new.

[phnx47]

@sonkt You cannot just delete new, put attributes to base class or use another property.

Look at LogicalDeleteWithUpdatedAt test:

dapper-repositories/tests/SqlGenerator.Tests/MsSqlGeneratorTests.cs

Lines 305 to 314 in bc12a29

	[Fact]
	public static void LogicalDeleteWithUpdatedAt()
	{
	ISqlGenerator<User> userSqlGenerator = new SqlGenerator<User>(_sqlConnector);
	var user = new User() { Id = 10 };
	var sqlQuery = userSqlGenerator.GetDelete(user);
	var sql = sqlQuery.GetSql();
	Assert.Equal("UPDATE Users SET Deleted = 1, UpdatedAt = @UpdatedAt WHERE Users.Id = @Id", sql);
	}

[sonkt]

Here is Base class

Here is Test class

This is in DeleteAsync:

And ModifyDeletedInstance to update DeletedDate and IsDeleted = true;

And my problem did not solved.

[phnx47]

@sonkt Need [Status] and [Deleted] attributes

[sonkt]

Hi @phnx47 !
I found a problem is bool? (Allow null). Logical Delete will be work when property has 2 attributes are Status, Deleted and its data type is bool (not allow null).
I use these attributes for base class, and I can use new modifier to allow hard delete at derive class

Could you fix it for allow null data type.

[phnx47]

@sonkt yes

[sonkt]

Hi @phnx47 . After I upgraded to 1.26.0, Generated Sql has IsDeleted IS NULL with AND clause. This make my query is failed with data has IsDeleted =0

[phnx47]

@sonkt Hi! With 'bool?' use NULL instead of 0.

[sonkt]

Yes, I know, but with DB First, I must be updated all records from 0 to null. And with some cases, there are different between Null value and 0 value.