Skip to content

Commit 6bb8de9

Browse files
committed
fix: add trim() to adapter detectors for consistent whitespace handling
Update all adapter detector classes to use trim() when checking for empty strings, ensuring whitespace-only strings properly fall back to parent detectors. This aligns adapter detectors with the pattern used in base detector classes. Changes: - Twitter: AuthorName, Description - Wikipedia: Title, Description - Archive: Title, AuthorName, Description - ImageShack: Title, AuthorName, Description - Gist: AuthorName
1 parent feaecea commit 6bb8de9

File tree

11 files changed

+11
-11
lines changed

11 files changed

+11
-11
lines changed

src/Adapters/Archive/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('metadata', 'creator');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Archive/Detectors/Description.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('metadata', 'extract');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Archive/Detectors/Title.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('metadata', 'title');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Gist/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('owner');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/ImageShack/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('owner', 'username');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/ImageShack/Detectors/Description.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('description');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/ImageShack/Detectors/Title.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('title');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Twitter/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('includes', 'users', '0', 'name');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Twitter/Detectors/Description.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('data', 'text');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Wikipedia/Detectors/Description.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('extract');
18-
return (is_string($result) && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && trim($result) !== '') ? $result : parent::detect();
1919
}
2020
}

0 commit comments

Comments
 (0)