Skip to content

Commit cfa2b6d

Browse files
committed
refactoring: improve readable code.
1 parent 22de3cc commit cfa2b6d

File tree

14 files changed

+14
-14
lines changed

14 files changed

+14
-14
lines changed

src/Adapters/Archive/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('metadata', 'creator');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Archive/Detectors/Description.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('metadata', 'extract');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Archive/Detectors/Title.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('metadata', 'title');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Gist/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('owner');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Gist/Detectors/AuthorUrl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public function detect(): ?UriInterface
1616
$api = $extractor->getApi();
1717
$owner = $api->str('owner');
1818

19-
if ($owner !== null && $owner !== '') {
19+
if (is_string($owner) && $owner !== '') {
2020
return $extractor->getCrawler()->createUri("https://github.com/{$owner}");
2121
}
2222

src/Adapters/ImageShack/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('owner', 'username');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/ImageShack/Detectors/AuthorUrl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public function detect(): ?UriInterface
1616
$api = $extractor->getApi();
1717
$owner = $api->str('owner', 'username');
1818

19-
if ($owner !== null && $owner !== '') {
19+
if (is_string($owner) && $owner !== '') {
2020
return $extractor->getCrawler()->createUri("https://imageshack.com/{$owner}");
2121
}
2222

src/Adapters/ImageShack/Detectors/Description.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('description');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/ImageShack/Detectors/Title.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('title');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

src/Adapters/Twitter/Detectors/AuthorName.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ public function detect(): ?string
1515
$api = $extractor->getApi();
1616

1717
$result = $api->str('includes', 'users', '0', 'name');
18-
return ($result !== null && $result !== '') ? $result : parent::detect();
18+
return (is_string($result) && $result !== '') ? $result : parent::detect();
1919
}
2020
}

0 commit comments

Comments
 (0)