Skip to content

Commit b110c44

Browse files
gplanchatJoMessina
authored andcommitted
Changed the variadic methods to use array_push instead of foreach
1 parent ef45ba6 commit b110c44

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/FilterGroup.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public function withFilter(FilterInterface $filter): self
2121

2222
public function withFilters(FilterInterface ...$filters): self
2323
{
24-
array_push($this->filters, ...$filters);
24+
array_push($this->filters, ...$filters);
2525

2626
return $this;
2727
}
@@ -32,7 +32,7 @@ public function withFilters(FilterInterface ...$filters): self
3232
*/
3333
public function walkFilters(array $parameters, int $groupIndex = 0): \Traversable
3434
{
35-
if (count($this->filters) < 1) {
35+
if (\count($this->filters) < 1) {
3636
return;
3737
}
3838

@@ -52,33 +52,33 @@ private function buildFilters(array $parameters, int $groupIndex, int $filterInd
5252
sprintf('searchCriteria[filterGroups][%s][filters][%s][field]', $groupIndex, $filterIndex) => $current['field'],
5353
sprintf('searchCriteria[filterGroups][%s][filters][%s][value]', $groupIndex, $filterIndex) => $current['value'],
5454
sprintf('searchCriteria[filterGroups][%s][filters][%s][conditionType]', $groupIndex, $filterIndex) => $current['conditionType'],
55-
]
55+
],
5656
];
5757

58-
if (count($next) >= 1) {
58+
if (\count($next) >= 1) {
5959
yield from $this->buildFilters($childParameters, $groupIndex, $filterIndex + 1, ...$next);
6060
} else {
6161
yield $childParameters;
6262
}
6363
}
6464
}
6565

66-
public function greaterThan(string $field, int|float|string|\DateTimeInterface $value): self
66+
public function greaterThan(string $field, \DateTimeInterface|float|int|string $value): self
6767
{
6868
return $this->withFilter(new ScalarFilter($field, 'gt', $value));
6969
}
7070

71-
public function lowerThan(string $field, int|float|string|\DateTimeInterface $value): self
71+
public function lowerThan(string $field, \DateTimeInterface|float|int|string $value): self
7272
{
7373
return $this->withFilter(new ScalarFilter($field, 'lt', $value));
7474
}
7575

76-
public function greaterThanOrEqual(string $field, int|float|string|\DateTimeInterface $value): self
76+
public function greaterThanOrEqual(string $field, \DateTimeInterface|float|int|string $value): self
7777
{
7878
return $this->withFilter(new ScalarFilter($field, 'gteq', $value));
7979
}
8080

81-
public function lowerThanOrEqual(string $field, int|float|string|\DateTimeInterface $value): self
81+
public function lowerThanOrEqual(string $field, \DateTimeInterface|float|int|string $value): self
8282
{
8383
return $this->withFilter(new ScalarFilter($field, 'lteq', $value));
8484
}

src/QueryParameters.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function withGroup(FilterGroup $group): self
1818

1919
public function withGroups(FilterGroup ...$groups): self
2020
{
21-
array_push($this->groups, ...$groups);
21+
array_push($this->groups, ...$groups);
2222

2323
return $this;
2424
}
@@ -29,7 +29,7 @@ public function withGroups(FilterGroup ...$groups): self
2929
*/
3030
public function walkVariants(array $parameters = []): \Traversable
3131
{
32-
if (count($this->groups) < 1) {
32+
if (\count($this->groups) < 1) {
3333
return;
3434
}
3535

@@ -43,7 +43,7 @@ public function walkVariants(array $parameters = []): \Traversable
4343
private function buildFilters(array $parameters, int $groupIndex, FilterGroup $first, FilterGroup ...$next): \Traversable
4444
{
4545
foreach ($first->walkFilters($parameters, $groupIndex) as $current) {
46-
if (count($next) >= 1) {
46+
if (\count($next) >= 1) {
4747
yield from $this->buildFilters($current, $groupIndex + 1, ...$next);
4848
} else {
4949
yield $current;

0 commit comments

Comments
 (0)