Skip to content

Update documentation on RetryPlugin #232

Open
@Nyholm

Description

@Nyholm
Member

The plugin has some new parameters that should be documented.

Activity

kozlice

kozlice commented on May 20, 2018

@kozlice

It's also confusing that parameter retry is called retries in docs. I had to check the actual configurator's source code to find out why it wasn't working. The comment there says // TODO: should be called retries for consistency with the class :)

dbu

dbu commented on May 23, 2018

@dbu
Contributor

uh. then we should probably support both, but report a deprecation warning when using retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dbu@kozlice@Nyholm

        Issue actions

          Update documentation on RetryPlugin · Issue #232 · php-http/documentation