Skip to content

Commit 4a017c3

Browse files
committed
Got word of a probable bug, lead to me figuring out the test was dirty, fixing test and see what might come up from CI.
1 parent 0c40031 commit 4a017c3

File tree

3 files changed

+18
-7
lines changed

3 files changed

+18
-7
lines changed

Tests/DependencyInjection/CompilerPass/ConfigurationPassTest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ public function testAutowiring()
8181
$pass = new ConfigurationPass();
8282
$pass->process($container);
8383

84-
$this->assertAlias($container, get_class($eventDispatcherMock), EventDispatcherInterface::class);
85-
$this->assertAlias($container, get_class($httpClientMock), ClientInterface::class);
86-
$this->assertAlias($container, get_class($requestFactoryMock), RequestFactoryInterface::class);
87-
$this->assertAlias($container, get_class($responseFactoryMock), ResponseFactoryInterface::class);
88-
$this->assertAlias($container, get_class($streamFactoryMock), StreamFactoryInterface::class);
89-
$this->assertAlias($container, get_class($uriFactoryMock), UriFactoryInterface::class);
84+
$this->assertTag($container, get_class($eventDispatcherMock), TmdbSymfonyBundle::PSR14_EVENT_DISPATCHERS);
85+
$this->assertTag($container, get_class($httpClientMock), TmdbSymfonyBundle::PSR18_CLIENTS);
86+
$this->assertTag($container, get_class($requestFactoryMock), TmdbSymfonyBundle::PSR17_REQUEST_FACTORIES);
87+
$this->assertTag($container, get_class($responseFactoryMock), TmdbSymfonyBundle::PSR17_RESPONSE_FACTORIES);
88+
$this->assertTag($container, get_class($streamFactoryMock), TmdbSymfonyBundle::PSR17_STREAM_FACTORIES);
89+
$this->assertTag($container, get_class($uriFactoryMock), TmdbSymfonyBundle::PSR17_URI_FACTORIES);
9090
}
9191

9292
/**

Tests/DependencyInjection/TestCase.php

+10
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,16 @@ protected function assertAlias(ContainerBuilder $container, $value, $key): void
3030
$this->assertSame($value, (string)$container->getAlias($key), sprintf('%s alias is correct', $key));
3131
}
3232

33+
/**
34+
* @param ContainerBuilder $container
35+
* @param string $class
36+
* @param string $tag
37+
*/
38+
protected function assertTag(ContainerBuilder $container, string $class, string $tag): void
39+
{
40+
$this->assertArrayHasKey($class, $container->findTaggedServiceIds($tag));
41+
}
42+
3343
/**
3444
* @param string $key
3545
*/

composer.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@
4747
},
4848
"config": {
4949
"allow-plugins": {
50-
"dealerdirect/phpcodesniffer-composer-installer": true
50+
"dealerdirect/phpcodesniffer-composer-installer": true,
51+
"php-http/discovery": true
5152
}
5253
}
5354
}

0 commit comments

Comments
 (0)