Skip to content

Issue with streamWrapper::dir_readdir #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nielsdos opened this issue Apr 26, 2025 · 0 comments · Fixed by #4637
Closed

Issue with streamWrapper::dir_readdir #4635

nielsdos opened this issue Apr 26, 2025 · 0 comments · Fixed by #4637
Assignees
@nielsdos
Labels
bug Documentation contains incorrect information

Comments

@nielsdos
Copy link
Member

nielsdos commented Apr 26, 2025 •
edited
Loading

Affected page

https://www.php.net/manual/en/class.streamwrapper.php
and https://www.php.net/manual/en/streamwrapper.dir-readdir.php

Issue description

Return type says string but it should be string|false. You can see this in the description of return value false if there is no next file..

Steps to reproduce

Read the pages and be confused.

Suggested fix

Change return type to string|false and check if there are more of such cases.
@nielsdos nielsdos added the bug Documentation contains incorrect information label Apr 26, 2025
@nielsdos nielsdos self-assigned this Apr 26, 2025
@nielsdos nielsdos changed the title Issue with streamWrapper Issue with streamWrapper::dir_readdir Apr 26, 2025
nielsdos added a commit to nielsdos/doc-en that referenced this issue Apr 26, 2025
@nielsdos
Fix phpGH-4635: Issue with streamWrapper::dir_readdir
fea8c28
@nielsdos nielsdos linked a pull request Apr 26, 2025 that will close this issue
Fix return values of streamWrapper functions #4637
Merged
nielsdos added a commit to nielsdos/doc-en that referenced this issue Apr 29, 2025
@nielsdos
Fix phpGH-4635: Issue with streamWrapper::dir_readdir
1fa2e2a
nielsdos added a commit that referenced this issue Apr 29, 2025
@nielsdos
Fix GH-4635: Issue with streamWrapper::dir_readdir
e652ed9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nielsdos nielsdos

Labels
bug Documentation contains incorrect information
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix return values of streamWrapper functions nielsdos/doc-en
1 participant
@nielsdos