ext/intl: Throw TypeError for non-stringable timezone objects

Author: LamentXU123

NEWS

@@ -62,6 +62,8 @@ PHP                                                                        NEWS
   . Fixed bug GH-20426 (Spoofchecker::setRestrictionLevel() error message
     suggests missing constants). (DanielEScherzer)
   . Added grapheme_strrev (Yuya Hamada)
+  . Passing a non-stringable object as a time zone to Intl time zone
+    argument handling now raises TypeError instead of Error. (Weilin Du)
 
 - JSON:
   . Enriched JSON last error / exception message with error location.

UPGRADING

@@ -34,6 +34,10 @@ PHP 8.6 UPGRADE NOTES
     array arguments types/values and raise a TypeError/ValueError
     accordingly.
 
+- Intl:
+  . Passing a non-stringable object as a time zone to Intl APIs that accept
+    time zone objects or strings now raises a TypeError instead of an Error.
+
 - PCNTL:
   . pcntl_alarm() now raises a ValueError if the seconds argument is
     lower than zero or greater than platform's UINT_MAX.

ext/intl/tests/dateformat_setTimeZone_error.phpt

@@ -16,6 +16,12 @@ try {
 	echo $e::class, ': ', $e->getMessage(), PHP_EOL;
 }
 
+try {
+	$df->setTimeZone(new stdClass());
+} catch (Throwable $e) {
+	echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+
 try {
 	$df->setTimeZone('non existing timezone');
 } catch (Throwable $e) {
@@ -24,4 +30,5 @@ try {
 ?>
 --EXPECT--
 TypeError: IntlDateFormatter::setTimeZone(): Argument #1 ($timezone) must be of type object|string|null, array given
+TypeError: Object of class stdClass could not be converted to string
 IntlException: IntlDateFormatter::setTimeZone(): No such time zone: "non existing timezone"

ext/intl/timezone/timezone_class.cpp

@@ -160,8 +160,7 @@ U_CFUNC TimeZone *timezone_process_timezone_argument(
 				free_string = true;
 			} else {
 				if (!EG(exception)) {
-					// TODO Proper type error
-					zend_throw_error(nullptr, "Object of class %s could not be converted to string", ZSTR_VAL(timezone_object->ce->name));
+					zend_type_error("Object of class %s could not be converted to string", ZSTR_VAL(timezone_object->ce->name));
 				}
 				return nullptr;
 			}