Skip to content

Connect attributes to their targets #18553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomasfejfar opened this issue May 14, 2025 · 1 comment
Open

Connect attributes to their targets #18553

tomasfejfar opened this issue May 14, 2025 · 1 comment

Comments

@tomasfejfar
Copy link

Description

There currently seems to be no way to get the actual target of the attribute. The getTarget method returns the bitmask of the constants. Example usage:

class X {

#[Tag]
private string $property;

#[Tag]
private string $otherProperty;

private string $extraProperty;
}

...
$attributeReflections = $propertyReflection->getAttributes(Tag::class);
// now I want to pass the reflections somewhere else and do

$property = $attributeReflection->getPropertyReflection();
$property->getValue();

Obviously there is a workaround to build some datastructure to pass the reference in along with the reflection. But it seems like it should be part of the API. Given I can limit to what type of object I can attach it to, I should be able to get the actual "instance" of the object somehow IMHO. But maybe I'm missing some important context why this doesn't make sense, sorry if that's the case :)

Essentially it's the same as when ReflectionProperty has $class even though one could argue that you always get the property from class, so you should be able to maintain the relation yourself. I believe that property attribute should at least have $class and $property, if the above proposed API is too heavy.

Does it make sense?

@iluuu1994
Copy link
Member

This is possible, but ofc we wouldn't want to couple this API tightly to properties. Something like getTarget would be possible. One downside is that this strong reference to the target will prevent garbage collection to it, so it you just need to hold on to the attribute reflection itself, memory will slightly increase. But this is likely negligible. Otherwise, this should not be hard to implement. /cc @DanielEScherzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants