Skip to content

--libdir option default value #18579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remicollet opened this issue May 17, 2025 · 2 comments
Open

--libdir option default value #18579

remicollet opened this issue May 17, 2025 · 2 comments

Comments

@remicollet
Copy link
Member

remicollet commented May 17, 2025

Description

For years we use (for RPM build)

--libdir=/usr/lib64/php

excepted for embed SAPI which need the default path

--libdir=/usr/lib64

Since 0c07b0d this should not be necessary thanks to orig_libdir used for embded

orig_libdir=$libdir
AS_CASE([$libdir],
  ['${exec_prefix}/lib'], [libdir=$libdir/php])

AS_CASE([$(eval echo $datadir)],
  ['${prefix}/share'], [datadir=$datadir/php])

But the test does not work because of quote.

A proper test is probably (no quote + using php_libdir for lib64 case)

AS_CASE([$libdir],
  [${prefix}/${PHP_LIBDIR}], [libdir=$libdir/php])

Same issue with datadir, but this is only used for fpm/status.html page, other use datarootdir. Perhaps we can drop this check (to avoid change)

Help welcome on this

PHP Version

In PHP-8.4

Operating System

Linux

@remicollet
Copy link
Member Author

ping @adsr for 0c07b0d
ping @petk for db9a7aa

remicollet added a commit to remicollet/php-src that referenced this issue May 19, 2025
Using PHP_LIBDIR for lib64 case
Fix AS_CASE for libdir and datadir broken by quotes
@remicollet
Copy link
Member Author

Fix proposal in PR #18596 only to master to avoid file placement in stable release
(in some build, FPM status page will move from /usr/share/fpm to /usr/share/php/fpm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants