Add Alpine push job #20038
Add Alpine push job #20038
Conversation
arnaud-lb
force-pushed
the
alpine-push
branch
2 times, most recently
from
2cd8a63 to
36498b1
Compare
| runs-on: ubuntu-22.04 | ||
| container: | ||
| image: 'alpine:3.20.1' |
There was a problem hiding this comment.
I will modernize the push and nightly Alpine jobs in a separate PR.
The latest Alpine version has Clang 20, so we can have at least one job that runs the tailcall VM.
There was a problem hiding this comment.
Latest stable is 3.22 and it has clang 15-20 https://pkgs.alpinelinux.org/packages?name=clang1%3F&branch=v3.22&repo=&arch=x86_64&origin=&flagged=&maintainer=
|
@TimWolla I think this needs to target 8.1, but the job should not run in branches lower than 8.4 as the test suite will not pass. What would be the best way to skip lower branches? |
Why do you think so? Just target 8.4 then. Some differences in CI between the branches is normal and expected. |
|
We only keep the root.yml and nightly.yml files synced between branches. push.yml may freely diverge. I'm not sure if this build is really necessary though? I haven't seen many failures for alpine in nightly that were missed when merging. My thinking is, it's not worth running dozens of jobs daily to prevent a merge that needs correction every few weeks/months. Push will never be able to find all issues. But I'll leave that at your discretion. |
Ah thank you, I had understood that all workflows were maintained in 8.1.
@bukka anticipated this would be useful while he works on streams. I will leave the PR open for now, @bukka feel free to merge it. |
|
Yeah I might be hitting this more for low level networking stuff so it's useful for me. |
|
The alternative is to run it conditionally, e.g. when adding some keyword to the commit message. This would be useful for other jobs as well, though in that case it might make sense to try to combine nightly with push somehow. |
|
Maybe but I don't have any time for it and would like to have it in pipeline tested. Fixing nightly failures is slower and also having UBSAN is good. Btw this job caught two issues in my single PR fixed in e68396c and a3c14d6 which took extra of my time to get fixed. Triggering extra job (or adding some special commit message or even PR message) for each of my PR would be quite annoying as I would need to do it constantly. But I agree that it might be useful for other jobs that are not that useful. |
No description provided.