Skip to content

Commit fd1338e

Browse files
committed
Revert "Add automatic fixtures generator importer"
This reverts commit 5cdac95. Due to the #77 discussion and request from a prominent member of the PHP group - Kalle - I'm reverting this awesome addition because it caused too many conflicts and issues. So it is not worth of investing more from my side into this neither having a ruined experience further on from any side here. This fix has been really helpful with some development ways but people who maintain this app further better have peace of mind...
1 parent 95cdd55 commit fd1338e

File tree

11 files changed

+10
-1132
lines changed

11 files changed

+10
-1132
lines changed

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
# Local specific PHPUnit configuration
1414
/phpunit.xml
15-
/.phpunit.result.cache
15+
.phpunit.result.cache
1616

1717
# Transient and temporary generated files
1818
/var/

README.md

+3-9
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,8 @@ Modify `local_config.php` according to your local development environment.
1717

1818
* Database:
1919

20-
Create a new MySQL, MariaDB, Percona Server, or equivalent database using
21-
`sql/database.sql`, create database schema `sql/schema.sql` and insert demo data
22-
fixtures by running:
23-
24-
```bash
25-
php scripts/console app:fixtures:insert
26-
```
20+
Create a new MySQL/MariaDB database using `sql/database.sql`, create database
21+
schema `sql/schema.sql` and insert fixtures using `sql/fixtures.sql`.
2722

2823
## Tests
2924

@@ -47,10 +42,9 @@ Source code of this application is structured in the following directories:
4742
├─ prepend.php # Autoloader, DB connection, container, app initialization
4843
└─ ...
4944
└─ scripts/ # Command line development tools and scripts
50-
├─ console # Application's main script for running CLI commands
5145
├─ cron/ # Various systems scripts to run periodically on the server
5246
└─ ...
53-
├─ sql/ # Database schema
47+
├─ sql/ # Database schema and fixtures
5448
└─ src/ # Application source code classes
5549
├─ Horde/ # https://www.horde.org/libraries/Horde_Text_Diff
5650
└─ ...

composer.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@
3232
},
3333
"require-dev": {
3434
"ext-pdo_sqlite": "*",
35-
"fzaninotto/faker": "^1.8",
36-
"phpunit/phpunit": "^8.1.5",
37-
"symfony/console": "^4.2"
35+
"phpunit/phpunit": "^8.1.5"
3836
},
3937
"autoload": {
4038
"psr-4": {

composer.lock

+1-253
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/container.php

-21
Original file line numberDiff line numberDiff line change
@@ -89,25 +89,4 @@
8989
return new App\Utils\Uploader();
9090
});
9191

92-
$container->set(App\Fixtures\AppFixtures::class, function ($c) {
93-
return new App\Fixtures\AppFixtures($c->get(\PDO::class), Faker\Factory::create(), $c->get('bug_statuses'));
94-
});
95-
96-
$container->set(App\Command\InsertFixturesCommand::class, function ($c) {
97-
$insertFixturesCommand = new App\Command\InsertFixturesCommand(
98-
$c->get(\PDO::class),
99-
$c->get(App\Fixtures\AppFixtures::class),
100-
$c->get('env')
101-
);
102-
103-
return $insertFixturesCommand;
104-
});
105-
106-
$container->set(Symfony\Component\Console\Application::class, function ($c) {
107-
$application = new Symfony\Component\Console\Application();
108-
$application->add($c->get(App\Command\InsertFixturesCommand::class));
109-
110-
return $application;
111-
});
112-
11392
return $container;

config/parameters.php

-20
Original file line numberDiff line numberDiff line change
@@ -70,24 +70,4 @@
7070
* Templates directory.
7171
*/
7272
'templates_dir' => __DIR__.'/../templates',
73-
74-
/**
75-
* Bug statuses.
76-
*/
77-
'bug_statuses' => [
78-
'Open' => 'Opn',
79-
'Not a bug' => 'Nab',
80-
'Feedback' => 'Fbk',
81-
'No Feedback' => 'NoF',
82-
'Wont fix' => 'Wfx',
83-
'Duplicate' => 'Dup',
84-
'Critical' => 'Ctl',
85-
'Assigned' => 'Asn',
86-
'Analyzed' => 'Ana',
87-
'Verified' => 'Ver',
88-
'Suspended' => 'Sus',
89-
'Closed' => 'Csd',
90-
'Spam' => 'Spm',
91-
'Re-Opened' => 'ReO',
92-
],
9373
];

scripts/console

-15
This file was deleted.

0 commit comments

Comments
 (0)