tests improvements: make data provider methods static (#466)

Author: micheleorselli

tests/Unit/Analyzer/FileVisitorTest.php

@@ -1374,88 +1374,88 @@ public function test_it_parse_enums(string $code): void
         }
     }
 
-    public function provide_enums(): \Generator
+    public static function provide_enums(): \Generator
     {
         yield 'default enum' => [
             <<< 'EOF'
-<?php
-namespace App\Foo;
+            <?php
+            namespace App\Foo;
 
-enum DefaultEnum
-{
-    case FOO;
-}
-EOF
+            enum DefaultEnum
+            {
+                case FOO;
+            }
+            EOF
         ];
 
         yield 'string enum' => [
             <<< 'EOF'
-<?php
-namespace App\Foo;
+            <?php
+            namespace App\Foo;
 
-enum StringEnum: string
-{
-    case BAR: 'bar';
-}
-EOF
+            enum StringEnum: string
+            {
+                case BAR: 'bar';
+            }
+            EOF
         ];
 
         yield 'integer enum' => [
             <<< 'EOF'
-<?php
-namespace App\Foo;
+            <?php
+            namespace App\Foo;
 
-enum IntEnum: int
-{
-    case BAZ: 42;
-}
-EOF
+            enum IntEnum: int
+            {
+                case BAZ: 42;
+            }
+            EOF
         ];
 
         yield 'multiple enums' => [
             <<< 'EOF'
-<?php
-namespace App\Foo;
+            <?php
+            namespace App\Foo;
 
-enum DefaultEnum
-{
-    case FOO;
-}
+            enum DefaultEnum
+            {
+                case FOO;
+            }
 
-enum IntEnum: int
-{
-    case BAZ: 42;
-}
+            enum IntEnum: int
+            {
+                case BAZ: 42;
+            }
 
-enum IntEnum: int
-{
-    case BAZ: 42;
-}
-EOF
+            enum IntEnum: int
+            {
+                case BAZ: 42;
+            }
+            EOF
         ];
     }
 
     public function test_it_parse_property_hooks(): void
     {
         $code = <<< 'EOF'
-<?php
-namespace App\Foo;
+        <?php
+        namespace App\Foo;
 
-class User {
-    private string $firstName;
-    private string $lastName;
+        class User {
+            private string $firstName;
+            private string $lastName;
 
-    public function __construct(string $firstName, string $lastName) {
-        $this->firstName = $firstName;
-        $this->lastName = $lastName;
-    }
+            public function __construct(string $firstName, string $lastName) {
+                $this->firstName = $firstName;
+                $this->lastName = $lastName;
+            }
 
-    public string $fullName {
-        get => $this->firstName . ' ' . $this->lastName;
-        set {[$this->firstName, $this->lastName] = explode(' ', $value, 2);}
-    }
-}
-EOF;
+            public string $fullName {
+                get => $this->firstName . ' ' . $this->lastName;
+                set {[$this->firstName, $this->lastName] = explode(' ', $value, 2);}
+            }
+        }
+        EOF;
 
         /** @var FileParser $fp */
         $fp = FileParserFactory::createFileParser(TargetPhpVersion::create('8.4'));

tests/Unit/Analyzer/FullyQualifiedClassNameTest.php

@@ -8,7 +8,7 @@
 
 class FullyQualifiedClassNameTest extends TestCase
 {
-    public function patternProvider(): array
+    public static function patternProvider(): array
     {
         return [
             ['Food\Vegetables\Fruits\Banana', 'Food\Vegetables\Fruits\Banana', true],

tests/Unit/Analyzer/PatternStringTest.php

@@ -23,7 +23,7 @@ public function test_wildcard_is_for_alphanumeric(string $string, string $patter
         $this->assertEquals($expectedResult, (new PatternString($string))->matches($pattern));
     }
 
-    public function providePatterns(): array
+    public static function providePatterns(): array
     {
         return [
             ['SoThisIsAnExample', '*This*', true],

tests/Unit/Expressions/ForClasses/ResideInOneOfTheseNamespacesTest.php

@@ -11,7 +11,7 @@
 
 class ResideInOneOfTheseNamespacesTest extends TestCase
 {
-    public function shouldMatchNamespacesProvider(): array
+    public static function shouldMatchNamespacesProvider(): array
     {
         return [
             ['Food\Vegetables', 'Food\Vegetables\Carrot', 'matches a class in the root namespace'],