Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubs are missing class constants and properties #1

Open
ondrejmirtes opened this issue Oct 5, 2020 · 4 comments
Open

Stubs are missing class constants and properties #1

ondrejmirtes opened this issue Oct 5, 2020 · 4 comments

Comments

@ondrejmirtes
Copy link
Member

https://bugs.php.net/bug.php?id=80188

@kocsismate
Copy link

I've just started to declare constants (e.g. php/php-src#8630) :) Besides, almost all properties have been declared in the meanwhile. The majority of the exceptions will be merged soon: php/php-src#8534 and php/php-src#8515

@kocsismate
Copy link

P.S. I've just noticed that https://github.com/phpstan/php-8-stubs/blob/main/extractor/extract.php#L589 is counterproductive since PHP 8.1: it removes the tentative return type. The same is true for PDO::getAttribute().

@ondrejmirtes
Copy link
Member Author

@kocsismate Can you actually make PHPStan fail (false positive) or succeed (false negative) with a relevant bug on phpstan.org/try? Besides php-8-stubs, PHPStan also uses jetbrains/phpstorm-stubs and this file: https://github.com/phpstan/phpstan-src/blob/1.7.x/resources/functionMap.php

The logic how each of these sources are used and merged isn't trivial...

@kocsismate
Copy link

Done: phpstan/phpstan#7317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants