Make TypeTraverserMapMemoizedRule a regular rule

TypeTraverser::map() and mapMemoized() are @api, so extensions get the same
guidance. Tests keep using map() where they exercise it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Author: phpstan-bot

build/phpstan.neon

@@ -81,6 +81,10 @@ parameters:
 		- '#^Dynamic call to static method PHPUnit\\Framework\\\S+\(\)\.$#'
 		- '#should be contravariant with parameter \$node \(PhpParser\\Node\) of method PHPStan\\Rules\\Rule<PhpParser\\Node>::processNode\(\)$#'
 		- '#Variable property access on PhpParser\\Node#'
+		-
+			identifier: phpstanApi.typeTraverserMap
+			path: ../tests/* # tests exercise TypeTraverser::map() itself
+			reportUnmatched: false
 		-
 			identifier: shipmonk.deadMethod
 			message: '#^Unused .*?::__construct#' # likely used in DIC
@@ -208,7 +212,6 @@ rules:
 	- PHPStan\Build\MemoizationPropertyRule
 	- PHPStan\Build\OrChainIdenticalComparisonToInArrayRule
 	- PHPStan\Build\NoPhpVersionInjectionInScopeAwareExtensionRule
-	- PHPStan\Build\TypeTraverserMapMemoizedRule
 
 services:
 	-

…n/Build/TypeTraverserMapMemoizedRule.php …les/Api/TypeTraverserMapMemoizedRule.phpbuild/PHPStan/Build/TypeTraverserMapMemoizedRule.php renamed to src/Rules/Api/TypeTraverserMapMemoizedRule.php build/PHPStan/Build/TypeTraverserMapMemoizedRule.php renamed to src/Rules/Api/TypeTraverserMapMemoizedRule.php

@@ -1,6 +1,6 @@
 <?php declare(strict_types = 1);
 
-namespace PHPStan\Build;
+namespace PHPStan\Rules\Api;
 
 use PhpParser\Node;
 use PhpParser\Node\Expr;
@@ -28,21 +28,19 @@
 use PhpParser\Node\Stmt\Unset_;
 use PhpParser\NodeFinder;
 use PHPStan\Analyser\Scope;
-use PHPStan\File\FileHelper;
+use PHPStan\DependencyInjection\RegisteredRule;
 use PHPStan\Rules\IdentifierRuleError;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\TypeTraverser;
 use function array_unique;
 use function array_values;
 use function count;
-use function dirname;
 use function implode;
 use function in_array;
 use function is_string;
 use function spl_object_id;
 use function sprintf;
-use function str_starts_with;
 
 /**
  * Keeps the choice between TypeTraverser::map() and TypeTraverser::mapMemoized()
@@ -64,13 +62,10 @@
  *
  * @implements Rule<StaticCall>
  */
+#[RegisteredRule(level: 0)]
 final class TypeTraverserMapMemoizedRule implements Rule
 {
 
-	public function __construct(private FileHelper $fileHelper, private bool $skipTests = true)
-	{
-	}
-
 	public function getNodeType(): string
 	{
 		return StaticCall::class;
@@ -87,10 +82,6 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if ($this->skipTests && str_starts_with($this->fileHelper->normalizePath($scope->getFile()), $this->fileHelper->normalizePath(dirname(__DIR__, 3) . '/tests'))) {
-			return [];
-		}
-
 		// the result is not used when the call is a statement of its own;
 		// the body of an arrow function also counts as one, which errs towards allowing mapMemoized()
 		$error = $this->checkCall($node, $scope->isInFirstLevelStatement());
@@ -123,7 +114,7 @@ private function checkCall(StaticCall $call, bool $isResultUnused): ?IdentifierR
 				'Callback of TypeTraverser::mapMemoized() %s, so it might depend on where or how many times a Type instance occurs. Use TypeTraverser::map() instead.',
 				implode(', ', $reasons),
 			))
-				->identifier('phpstan.typeTraverserMapMemoized')
+				->identifier('phpstanApi.typeTraverserMapMemoized')
 				->line($call->getStartLine())
 				->build();
 		}
@@ -133,7 +124,7 @@ private function checkCall(StaticCall $call, bool $isResultUnused): ?IdentifierR
 		}
 
 		return RuleErrorBuilder::message('Callback of TypeTraverser::map() does not depend on where or how many times a Type instance occurs. Use TypeTraverser::mapMemoized() instead.')
-			->identifier('phpstan.typeTraverserMap')
+			->identifier('phpstanApi.typeTraverserMap')
 			->line($call->getStartLine())
 			->fixNode($call, static function (StaticCall $node): StaticCall {
 				$node->name = new Identifier('mapMemoized');

src/Type/TypeTraverser.php

@@ -62,6 +62,7 @@ public static function map(Type $type, TypeTraverserCallable|callable $cb): Type
 	 * Only for callbacks whose result and side effects do not depend on
 	 * where in the traversed type, or how many times, the type occurs.
 	 *
+	 * @api
 	 * @param TypeTraverserCallable|callable(Type $type, callable(Type): Type $traverse): Type $cb
 	 */
 	public static function mapMemoized(Type $type, TypeTraverserCallable|callable $cb): Type

…ild/TypeTraverserMapMemoizedRuleTest.php …Api/TypeTraverserMapMemoizedRuleTest.phptests/PHPStan/Build/TypeTraverserMapMemoizedRuleTest.php renamed to tests/PHPStan/Rules/Api/TypeTraverserMapMemoizedRuleTest.php tests/PHPStan/Build/TypeTraverserMapMemoizedRuleTest.php renamed to tests/PHPStan/Rules/Api/TypeTraverserMapMemoizedRuleTest.php

@@ -1,8 +1,7 @@
 <?php declare(strict_types = 1);
 
-namespace PHPStan\Build;
+namespace PHPStan\Rules\Api;
 
-use PHPStan\File\FileHelper;
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 
@@ -14,7 +13,7 @@ final class TypeTraverserMapMemoizedRuleTest extends RuleTestCase
 
 	protected function getRule(): Rule
 	{
-		return new TypeTraverserMapMemoizedRule(self::getContainer()->getByType(FileHelper::class), false);
+		return new TypeTraverserMapMemoizedRule();
 	}
 
 	public function testRule(): void