Drop comments that restate the code

The two comments in the generator described what the loops below them plainly
do. In SimpleImpurePoint, resolvePureUnlessParameterPassedVerdict() and
narrowByConditionalPurity() read off their names, and the Yes/No/Maybe gloss
on resolveConditionalPurityVerdict() explained TrinaryLogic rather than this
method. Kept only the parts that are not obvious: that a function can carry
both flags at once, and when each verdict returns null.

Author: zonuexe

bin/generate-function-metadata.php

@@ -132,9 +132,6 @@ public function enterNode(Node $node)
 				throw new ShouldNotHappenException($functionName);
 			}
 
-			// An entry can carry both conditions at once (e.g. preg_replace_callback,
-			// which is pure unless its callback is impure or its 'count' is passed),
-			// so keep every condition the hand-maintained entry declares.
 			$conditions = [];
 			foreach (['pureUnlessCallableIsImpureParameters', 'pureUnlessParameterPassedParameters'] as $conditionKey) {
 				if (!isset($metadata[$functionName][$conditionKey])) {
@@ -232,8 +229,6 @@ public function enterNode(Node $node)
 	);
 
 	foreach ($metadata as $name => $meta) {
-		// An entry is either unconditional or carries one or both of the conditional
-		// purity keys, so encode every key it has instead of just the first one.
 		$entries = [];
 		if (isset($meta['hasSideEffects'])) {
 			$entries[] = sprintf('%s => %s', $escape('hasSideEffects'), $escape($meta['hasSideEffects']));

src/Reflection/Callables/SimpleImpurePoint.php

@@ -135,13 +135,9 @@ public static function createFromVariant(FunctionReflection|ExtendedMethodReflec
 	}
 
 	/**
-	 * Purity verdict of a call to a variant that declares conditional purity.
-	 *
 	 * A function can carry both flags at once (e.g. preg_replace_callback, which is
-	 * pure unless its callback is impure or its $count is passed). It stays pure only
-	 * when both verdicts agree it is pure, so they are combined: Yes = pure,
-	 * No = impure, Maybe = possibly impure. Returns null when the variant declares
-	 * neither flag, so the caller keeps its current behavior.
+	 * pure unless its callback is impure or its $count is passed), so the two
+	 * verdicts are combined. Returns null when the variant declares neither flag.
 	 *
 	 * @param Arg[] $args
 	 */
@@ -157,11 +153,6 @@ public static function resolveConditionalPurityVerdict(ParametersAcceptor $varia
 	}
 
 	/**
-	 * Applies the conditional purity verdict of this call site to impure points that
-	 * were resolved without one - a callable value's impure points are computed from
-	 * its ParametersAcceptor alone, so a first-class callable of a conditionally pure
-	 * function arrives here as an unconditional "possibly impure" point.
-	 *
 	 * @param SimpleImpurePoint[] $impurePoints
 	 * @param Arg[] $args
 	 * @return SimpleImpurePoint[]
@@ -250,11 +241,7 @@ public static function resolvePureUnlessCallableIsImpureVerdict(ParametersAccept
 	}
 
 	/**
-	 * Purity verdict for parameters flagged with @pure-unless-parameter-passed:
-	 * the call stays pure as long as none of those (by-ref out) parameters
-	 * received an argument. Returns Yes when no flagged parameter was passed,
-	 * No when at least one was, and null when the variant has no such parameters
-	 * (so the caller keeps its current behavior).
+	 * Returns null when the variant has no flagged parameters.
 	 *
 	 * @param Arg[] $args
 	 */