Mark reflection parameter checks and type stringification as non-throwing

Author: ondrejmirtes

conf/config.neon

@@ -156,6 +156,7 @@ parameters:
 		- ../stubs/ReflectionMethod.stub
 		- ../stubs/ReflectionParameter.stub
 		- ../stubs/ReflectionProperty.stub
+		- ../stubs/ReflectionType.stub
 		- ../stubs/iterable.stub
 		- ../stubs/ArrayObject.stub
 		- ../stubs/WeakReference.stub

stubs/ReflectionParameter.stub

@@ -16,4 +16,11 @@ class ReflectionParameter
 	{
 	}
 
+	/**
+	 * @throws void
+	 */
+	public function isOptional(): bool
+	{
+	}
+
 }

stubs/ReflectionType.stub

@@ -0,0 +1,13 @@
+<?php
+
+abstract class ReflectionType
+{
+
+	/**
+	 * @throws void
+	 */
+	public function __toString(): string
+	{
+	}
+
+}

tests/PHPStan/Analyser/nsrt/reflection-parameter-type-catch.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace ReflectionParameterTypeCatch;
+
+use function PHPStan\Testing\assertType;
+
+/** @param class-string $className */
+function parameterType(string $className, string $propertyName): void
+{
+	$sourceInterfaceReflection = new \ReflectionClass($className);
+	$paramType = null;
+	try {
+		$reflectionMethod = $sourceInterfaceReflection->getMethod('set' . ucfirst($propertyName));
+		$reflectionParams = $reflectionMethod->getParameters();
+		if (isset($reflectionParams[0])) {
+			$paramType = $reflectionParams[0]->getType();
+			if (($paramType !== null) && $reflectionParams[0]->isOptional()) {
+				$paramType = '?' . $paramType;
+			}
+		}
+
+		if ($paramType !== null) {
+			$paramType = (string) $paramType;
+		}
+	} catch (\Exception $e) {
+	}
+
+	assertType('string|null', $paramType);
+}
+
+function stringifyType(\ReflectionType $type): void
+{
+	$string = null;
+	try {
+		$string = (string) $type;
+	} catch (\Exception $e) {
+	}
+
+	assertType('string', $string);
+}
+
+function checkOptional(\ReflectionParameter $parameter): void
+{
+	$optional = null;
+	try {
+		$optional = $parameter->isOptional();
+	} catch (\Exception $e) {
+	}
+
+	assertType('bool', $optional);
+}