src/Rules/Api/*Rule: cheap checks first (#6206)

Author: staabm

src/Rules/Api/NodeConnectingVisitorAttributesRule.php

@@ -34,15 +34,17 @@ public function processNode(Node $node, Scope $scope): array
 		if ($node->name->toLowerString() !== 'getattribute') {
 			return [];
 		}
-		$calledOnType = $scope->getType($node->var);
-		if (!(new ObjectType(Node::class))->isSuperTypeOf($calledOnType)->yes()) {
-			return [];
-		}
+
 		$args = $node->getArgs();
 		if (!isset($args[0])) {
 			return [];
 		}
 
+		$calledOnType = $scope->getType($node->var);
+		if (!(new ObjectType(Node::class))->isSuperTypeOf($calledOnType)->yes()) {
+			return [];
+		}
+
 		$messages = [];
 		$argType = $scope->getType($args[0]->value);
 		foreach ($argType->getConstantStrings() as $constantString) {

src/Rules/Api/OldPhpParser4ClassRule.php

@@ -42,6 +42,10 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
+		if (!$scope->isInClass()) {
+			return [];
+		}
+
 		$nameMapping = array_change_key_case(self::NAME_MAPPING);
 		$lowerName = $node->toLowerString();
 		if (!array_key_exists($lowerName, $nameMapping)) {
@@ -50,10 +54,6 @@ public function processNode(Node $node, Scope $scope): array
 
 		$newName = $nameMapping[$lowerName];
 
-		if (!$scope->isInClass()) {
-			return [];
-		}
-
 		$classReflection = $scope->getClassReflection();
 		$hasPhpStanInterface = false;
 		foreach (array_keys($classReflection->getInterfaces()) as $interfaceName) {

src/Rules/Api/RuntimeReflectionFunctionRule.php

@@ -35,6 +35,10 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		if (!$scope->isInClass()) {
+			return [];
+		}
+
 		if (!$this->reflectionProvider->hasFunction($node->name, $scope)) {
 			return [];
 		}
@@ -50,10 +54,6 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$scope->isInClass()) {
-			return [];
-		}
-
 		$classReflection = $scope->getClassReflection();
 		$hasPhpStanInterface = false;
 		foreach (array_keys($classReflection->getInterfaces()) as $interfaceName) {

src/Rules/Api/RuntimeReflectionInstantiationRule.php

@@ -45,6 +45,10 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		if (!$scope->isInClass()) {
+			return [];
+		}
+
 		$className = $scope->resolveName($node->class);
 		if (!$this->reflectionProvider->hasClass($className)) {
 			return [];
@@ -69,10 +73,6 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$scope->isInClass()) {
-			return [];
-		}
-
 		$scopeClassReflection = $scope->getClassReflection();
 		$hasPhpStanInterface = false;
 		foreach (array_keys($scopeClassReflection->getInterfaces()) as $interfaceName) {