Simplify the __debugInfo() condition and cover a PHP version range spanning 8.6 in EnumSanityRule

Author: Amoifr

src/Rules/Classes/EnumSanityRule.php

@@ -82,7 +82,7 @@ public function processNode(Node $node, Scope $scope): array
 						->build();
 				} elseif (
 					!array_key_exists($lowercasedMethodName, self::ALLOWED_MAGIC_METHODS)
-					&& !($lowercasedMethodName === '__debuginfo' && $scope->getPhpVersion()->supportsDebugInfoOnEnums()->yes())
+					&& ($lowercasedMethodName !== '__debuginfo' || !$scope->getPhpVersion()->supportsDebugInfoOnEnums()->yes())
 				) {
 					$errors[] = RuleErrorBuilder::message(sprintf(
 						'Enum %s contains magic method %s().',

tests/PHPStan/Rules/Classes/EnumSanityRuleConfigPhpTest.php

@@ -0,0 +1,45 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Classes;
+
+use PHPStan\Reflection\InitializerExprTypeResolver;
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+use PHPUnit\Framework\Attributes\RequiresPhp;
+
+/**
+ * @extends RuleTestCase<EnumSanityRule>
+ */
+class EnumSanityRuleConfigPhpTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new EnumSanityRule(
+			self::getContainer()->getByType(InitializerExprTypeResolver::class),
+		);
+	}
+
+	#[RequiresPhp('>= 8.1.0')]
+	public function testDebugInfoPhpVersionRangeSpanning86(): void
+	{
+		$this->analyse([__DIR__ . '/data/enum-debug-info-php-versions.php'], [
+			[
+				'Enum EnumDebugInfoPhpVersions\UnsupportedInBranch contains magic method __debugInfo().',
+				18,
+			],
+			[
+				'Enum EnumDebugInfoPhpVersions\DependsOnPhpVersion contains magic method __debugInfo().',
+				27,
+			],
+		]);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/data/enum-debug-info-php-version.neon',
+		];
+	}
+
+}

tests/PHPStan/Rules/Classes/data/enum-debug-info-php-version.neon

@@ -0,0 +1,4 @@
+parameters:
+    phpVersion:
+        min: 80500
+        max: 80600