Skip to content

Add trait bound ToString to Cell::new()/Cell::new_align() #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add trait bound ToString to Cell::new()/Cell::new_align() #94

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79b44b5
add type parameter to Cell::new()/Cell::new_align()
iosmanthus Oct 21, 2018
74c2bd2
Add trait bound ToString to Cell::new()/Cell::new_align()
iosmanthus Oct 21, 2018
d6db8b8
Merge branch 'master' of github.com:iosmanthus/prettytable-rs
iosmanthus Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/cell.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ pub struct Cell {
}

impl Cell {
/// Create a new `Cell` initialized with content from `string`.
/// Create a new `Cell` initialized with content from `string` which implemented `ToString`.
/// Text alignment in cell is configurable with the `align` argument
pub fn new_align(string: &str, align: Alignment) -> Cell {
let content: Vec<String> = string.lines().map(|x| x.to_string()).collect();
pub fn new_align<T: ToString + ?Sized>(string: &T, align: Alignment) -> Cell {
let content: Vec<String> = string.to_string().lines().map(|x| x.to_string()).collect();
let mut width = 0;
for cont in &content {
let l = display_width(&cont[..]);
Expand All @@ -42,9 +42,9 @@ impl Cell {
}
}

/// Create a new `Cell` initialized with content from `string`.
/// Create a new `Cell` initialized with content from `string` which implemented `ToString`.
/// By default, content is align to `LEFT`
pub fn new(string: &str) -> Cell {
pub fn new<T: ToString + ?Sized>(string: &T) -> Cell {
Cell::new_align(string, Alignment::LEFT)
}

Expand Down