Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document hidden PIHOLE_SELINUX variable #316

Open
3 tasks done
jb044 opened this issue May 13, 2020 · 1 comment
Open
3 tasks done

Document hidden PIHOLE_SELINUX variable #316

jb044 opened this issue May 13, 2020 · 1 comment
Assignees

Comments

@jb044
Copy link

jb044 commented May 13, 2020

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

How familiar are you with the the source code relevant to this issue?:

{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar}

7


Expected behaviour:

{A detailed description of what you expect to see}

pihole update code for 5 release checks for SELinux and exits if it is enabled, however there is also a shell variable PIHOLE_SELINUX. If this is set pihole -up continues with SELinux either enabled or enabled and in enforcing mode. I understand there are issues with pihole as is with SELinux and have taken measures to let it function with SELinux enforcing to a degree I can live with.

IMHO this variable should be either mentioned by the installer in update mode or documented. I just stumbled upon it in your source code.

Actual behaviour:

pihole -up on 4->5 updates pihole and the webinterface but not FTL, and thus breaks itself.

{A detailed description and/or screenshots of what you do see}

Steps to reproduce:

pihole -up on any system with SELinux enabled.

{Detailed steps of how we can reproduce this}

export PIHOLE_SELINUX=true

pihole -up

Succes

pihole -up

Failure

Debug token provided by uploading pihole -d log:

{Alphanumeric token}

Troubleshooting undertaken, and/or other relevant information:

{Steps of what you have done to fix this}

  • You must follow the template instructions. Failure to do so will result in your issue being closed.
  • Please submit any feature requests here, so it is votable and trackable by the community.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
  • Detail helps us understand and resolve an issue quicker, but please ensure it's relevant.
  • This template was created based on the work of udemy-dl.
@bcambl bcambl transferred this issue from pi-hole/pi-hole May 17, 2020
@bcambl bcambl changed the title pihole -up on centos 7 SELinux Document hidden PIHOLE_SELINUX variable May 17, 2020
@bcambl
Copy link
Member

bcambl commented May 17, 2020

@jb044 First off.. congrats finding my hidden variable! 🥇
Glad to hear you managed to build a policy that works for you.

I have renamed this issue and transfered it to the documentation repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants