Inspection "Explizit Initialization"on @Injectmocks should not be shown on Interface types

[boli14]

In Issue #55 there was Inspection introduced an Inspection that shows up, if there is an object annoted with @Injectmocks explizitly constructed with a default constructor. IE in the following case.

@InjectMocks
private Collection<String> collection = new ArrayList();

However normally i want to test my given class as an implementation of an interface. So in the above example I want to test ArrayList as a Collection and not as an ArrayList..

So my request is: The warning should not be shown for interfaces.

[picimako]

Hi @boli14,
Thanks for reaching out.

I've done a bit of investigation, and it turns out I was under the wrong impression. My understanding was that neither @Mock nor @InjectMocks annotations were supposed to have any initializer, but now I see that is not the case.

I think I'll disable (maybe ever temporarily remove) that inspection for now, and will look more deeply into it if it should be, or in what form it should be included in the plugin.

I'll do the changes today, and the new plugin version should be available in the next few days after JetBrains Marketplace review. Until then, you can turn it off in the IDE inspection settings.

[boli14]

Thx for the fast reaction!

However it would be nice to get a working version, which highlights places where one can really remove the initializer.

[picimako]

@boli14
You're welcome!
This topic seems interesting, so I'll definitely want to look into what criteria such fields must satisfy to be able to remove their initilizers.