refactor: reviews are not a pr status anymore

Author: neurosnap

__snapshots__/e2e_test.snap

@@ -35,7 +35,7 @@ ID RepoID           Name                       Status     Patchsets User
 7  contributor/ai   feat: lets build an rnn    [accepted] 1         admin       
 6  contributor/test Closed patch with review   [closed]   2         contributor 
 5  contributor/test Accepted patch with review [accepted] 2         contributor 
-4  contributor/test Reviewed patch             [reviewed] 2         contributor 
+4  contributor/test Reviewed patch             [open]     2         contributor 
 3  contributor/test Closed patch (contributor) [closed]   1         contributor 
 2  contributor/test Closed patch (admin)       [closed]   1         contributor 
 1  admin/test       Accepted patch             [accepted] 1         contributor 

cli.go

@@ -368,10 +368,6 @@ Here's how it works:
 								Name:  "accepted",
 								Usage: "only show accepted PRs",
 							},
-							&cli.BoolFlag{
-								Name:  "reviewed",
-								Usage: "only show reviewed PRs",
-							},
 							&cli.BoolFlag{
 								Name:  "mine",
 								Usage: "only show your own PRs",
@@ -406,7 +402,6 @@ Here's how it works:
 							onlyOpen := cCtx.Bool("open")
 							onlyAccepted := cCtx.Bool("accepted")
 							onlyClosed := cCtx.Bool("closed")
-							onlyReviewed := cCtx.Bool("reviewed")
 							onlyMine := cCtx.Bool("mine")
 
 							writer := NewTabWriter(sesh)
@@ -424,10 +419,6 @@ Here's how it works:
 									continue
 								}
 
-								if onlyReviewed && req.Status != "reviewed" {
-									continue
-								}
-
 								user, err := pr.GetUserByID(req.UserID)
 								if err != nil {
 									be.Logger.Error("could not get user for pr", "err", err)
@@ -846,7 +837,7 @@ Here's how it works:
 						Flags: []cli.Flag{
 							&cli.BoolFlag{
 								Name:  "review",
-								Usage: "submit patchset and mark PR as reviewed",
+								Usage: "submit patchset mark it as a review",
 							},
 							&cli.BoolFlag{
 								Name:  "accept",
@@ -898,8 +889,7 @@ Here's how it works:
 							op := OpNormal
 							nextStatus := "open"
 							if isReview {
-								wish.Println(sesh, "Marking PR as reviewed")
-								nextStatus = "reviewed"
+								wish.Println(sesh, "Marking patchset as a review")
 								op = OpReview
 							} else if isAccept {
 								wish.Println(sesh, "Marking PR as accepted")

tmpl/index.html

@@ -220,8 +220,6 @@ <h3 class="text-lg">format-patch workflow</h3>
     filter
     <a href="/">open</a> <code>{{.NumOpen}}</code>
     &middot;
-    <a href="/?status=reviewed">reviewed</a> <code>{{.NumReviewed}}</code>
-    &middot;
     <a href="/?status=accepted">accepted</a> <code>{{.NumAccepted}}</code>
     &middot;
     <a href="/?status=closed">closed</a> <code>{{.NumClosed}}</code>

tmpl/repo-detail.html

@@ -29,8 +29,6 @@ <h1 class="text-2xl mb"><a href="/">dashboard</a> / <a href="/r/{{.Username}}">{
     filter
     <a href="/r/{{.Username}}/{{.Name}}">open</a>
     &middot;
-    <a href="/r/{{.Username}}/{{.Name}}?status=reviewed">reviewed</a>
-    &middot;
     <a href="/r/{{.Username}}/{{.Name}}?status=accepted">accepted</a>
     &middot;
     <a href="/r/{{.Username}}/{{.Name}}?status=closed">closed</a>

tmpl/user-detail.html

@@ -28,8 +28,6 @@ <h1 class="text-2xl mb"><a href="/">dashboard</a> / {{.UserData.Name}}</h1>
     filter
     <a href="/r/{{.UserData.Name}}">open</a>
     &middot;
-    <a href="/r/{{.UserData.Name}}?status=reviewed">reviewed</a>
-    &middot;
     <a href="/r/{{.UserData.Name}}?status=accepted">accepted</a>
     &middot;
     <a href="/r/{{.UserData.Name}}?status=closed">closed</a>

web.go

@@ -112,7 +112,6 @@ type LinkData struct {
 type PrTableData struct {
 	Prs         []*PrListData
 	NumOpen     int
-	NumReviewed int
 	NumAccepted int
 	NumClosed   int
 	MetaData
@@ -291,15 +290,12 @@ func indexHandler(w http.ResponseWriter, r *http.Request) {
 	}
 
 	numOpen := 0
-	numReviewed := 0
 	numAccepted := 0
 	numClosed := 0
 	for _, pr := range prs {
 		switch pr.Status {
 		case "open":
 			numOpen += 1
-		case "reviewed":
-			numReviewed += 1
 		case "accepted":
 			numAccepted += 1
 		case "closed":
@@ -311,7 +307,6 @@ func indexHandler(w http.ResponseWriter, r *http.Request) {
 	tmpl := getTemplate("index.html")
 	err = tmpl.ExecuteTemplate(w, "index.html", PrTableData{
 		NumOpen:     numOpen,
-		NumReviewed: numReviewed,
 		NumAccepted: numAccepted,
 		NumClosed:   numClosed,
 		Prs:         prdata,