fix: single tenant doesnt require user namespace

Author: neurosnap

__snapshots__/e2e_test.snap

@@ -1,7 +1,8 @@
 
 [TestE2E - 1]
-ID RepoID Name                    Status Patchsets User  Date
-1  test   feat: lets build an rnn [open] 1         admin 
+ID RepoID Name                    Status Patchsets User        Date
+2  test   feat: lets build an rnn [open] 1         contributor 
+1  test   feat: lets build an rnn [open] 1         admin       
 
 ---
 

cli.go

@@ -489,14 +489,23 @@ Here's how it works:
 								rawRepoNs = args.First()
 							}
 							repoUsername, repoName := be.SplitRepoNs(rawRepoNs)
-							repoUser := user
-							if repoUsername != "" {
-								repoUser, err = pr.GetUserByName(repoUsername)
+							var repo *Repo
+							if repoUsername == "" {
+								if be.Cfg.CreateRepo == "admin" {
+									// single tenant default user to admin
+									repo, _ = pr.GetRepoByName(nil, repoName)
+								} else {
+									// multi tenant default user to contributor
+									repo, _ = pr.GetRepoByName(user, repoName)
+								}
+							} else {
+								repoUser, err := pr.GetUserByName(repoUsername)
 								if err != nil {
 									return err
 								}
+								repo, _ = pr.GetRepoByName(repoUser, repoName)
 							}
-							repo, _ := pr.GetRepoByName(repoUser, repoName)
+
 							err = be.CanCreateRepo(repo, user)
 							if err != nil {
 								return err

e2e_test.go

@@ -27,12 +27,17 @@ func testSingleTenantE2E(t *testing.T) {
 	go GitSshServer(suite.cfg, done)
 	// Hack to wait for startup
 	time.Sleep(time.Millisecond * 100)
+
+	t.Log("User cannot create repo")
 	_, err := suite.userKey.Cmd(suite.patch, "pr create test")
 	if err == nil {
 		t.Fatal("user should not be able to create a PR")
 	}
 	suite.adminKey.MustCmd(suite.patch, "pr create test")
 
+	t.Log("User should be able to create a patch")
+	suite.userKey.MustCmd(suite.patch, "pr create test")
+
 	t.Log("Snapshot test ls command")
 	actual, err := suite.userKey.Cmd(nil, "pr ls")
 	bail(err)

pr.go

@@ -147,9 +147,16 @@ func (pr PrCmd) GetRepos() (repos []*Repo, err error) {
 
 func (pr PrCmd) GetRepoByName(user *User, repoName string) (*Repo, error) {
 	var repo Repo
-	err := pr.Backend.DB.Get(&repo, "SELECT * FROM repos WHERE user_id=? AND name=?", user.ID, repoName)
+	var err error
+
+	if user == nil {
+		err = pr.Backend.DB.Get(&repo, "SELECT * FROM repos WHERE name=?", repoName)
+	} else {
+		err = pr.Backend.DB.Get(&repo, "SELECT * FROM repos WHERE user_id=? AND name=?", user.ID, repoName)
+	}
+
 	if err != nil {
-		return nil, fmt.Errorf("repo not found: %s/%s", user.Name, repoName)
+		return nil, fmt.Errorf("repo not found: %s", repoName)
 	}
 
 	return &repo, nil