More intuitive version matching #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids many issues with regex and glob patterns in version arguments matching incorrectly. Prevents invalid versions being requested from remote source. Always provides opportunity to confirm version being installed. Signed-off-by: Roy-Orbison <[email protected]>
Roy-Orbison
force-pushed
the
safer-matching
branch
from
43bb5c1
to
ffbf7c2
Compare
|
For testing, I have been using these extra lines to avoid thrashing & waiting for the remote: diff --git a/ubuntu-mainline-kernel.sh b/ubuntu-mainline-kernel.sh
index fc9c0c3..f60f946 100755
--- a/ubuntu-mainline-kernel.sh
+++ b/ubuntu-mainline-kernel.sh
@@ -369,6 +369,7 @@ latest_local_version() {
}
remote_html_cache=""
+remote_html_cache="$(cat < remote_html_cache)"
remote_versions_read=0
normalize_version_for_match() {
@@ -412,6 +413,7 @@ load_remote_versions () {
if [ -z "$remote_html_cache" ]; then
[ -z "$2" ] && logn "Downloading index from $ppa_host"
remote_html_cache=$(download $ppa_host $ppa_index)
+ cat <<<"$remote_html_cache" > remote_html_cache
[ -z "$2" ] && log
fi
@@ -609,6 +611,7 @@ Optional:
else
log
fi
+ exit
[ ! -d "$workdir" ] && {
mkdir -p "$workdir" 2>/dev/nullI used commands like these: ./ubuntu-mainline-kernel.sh -r 4.19 --rc./ubuntu-mainline-kernel.sh -i 4.19 -do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids many issues with regex and glob patterns in version arguments matching incorrectly. Prevents invalid versions being requested from remote source. Always provides opportunity to confirm version being installed.
Fixes #58.