json: extract the $[last] entry from json object should also return itself
#59687
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59687 +/- ##
================================================
+ Coverage 72.9533% 73.3632% +0.4098%
================================================
Files 1697 1697
Lines 468909 468949 +40
================================================
+ Hits 342085 344036 +1951
+ Misses 105773 103833 -1940
- Partials 21051 21080 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Defined2014
approved these changes
Feb 21, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #59619
Problem Summary:
json_extract('{"a":"b"}', '$[last]')should also return{"a":"b"}. It also affects thejson_setand any other json functions using the path.TiDB already handled the case for
$[0], but we didn't handle this case for$[last].What changed and how does it work?
Also return the object itself when the path is
$[last], just like$[0].Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.