Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global sort: check duplicate key at client side #59659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

global sort: check duplicate key at client side #59659

wants to merge 2 commits into from
+54 −1

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #59650

Problem Summary:

What changed and how does it work?

server side may return duplicate key error in IMPORT INTO + UK use case, but it's better to handle them at client side

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 20, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lance6716, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 20, 2025
@tiprow tiprow
Copy link

tiprow bot commented Feb 20, 2025

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
fix lint
faa825c 
Signed-off-by: lance6716 <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.5508%. Comparing base (97d861e) to head (faa825c).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #59659        +/-   ##
================================================
+ Coverage   72.9805%   73.5508%   +0.5703%     
================================================
  Files          1694       1725        +31     
  Lines        468596     477551      +8955     
================================================
+ Hits         341984     351243      +9259     
+ Misses       105568     104511      -1057     
- Partials      21044      21797       +753
Flag Coverage Δ
integration 45.5826% <28.5714%> (?)
unit 72.1839% <28.5714%> (-0.0037%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.0585% <ø> (-0.0452%) ⬇️

D3Hunter
D3Hunter reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@D3Hunter D3Hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/lightning/backend/local/region_job.go
Comment on lines +517 to +522
if needDupCheck {
if lastKey4DupCheck != nil && bytes.Equal(lastKey4DupCheck, k) {
return errors.Errorf("duplicate key found: %s", hex.EncodeToString(lastKey4DupCheck))
}
lastKey4DupCheck = k
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add in loadBatchRegionData where there is a sort phase, more simpler to check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the sorting of loadBatchRegionData there's no place to iterate all keys, so I need to add an iteration. I think it's better for performance to use current iteration here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IMPORT INTO + global sort didn't handle UK conflict correctly
2 participants
@lance6716 @D3Hunter