Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end-of-candidate to ICE Agent #311

Closed
wants to merge 1 commit into from
Closed

Add end-of-candidate to ICE Agent #311

wants to merge 1 commit into from

Conversation

scorpionknifes
Copy link
Member

Description

Based on pion/webrtc#1428 (comment)

  • Update pion/ice to accept a nil candidate. AddRemoteCandidate when called with nil should then set a field on the agent.
  • in the contact loop it shouldn't go to failed unless this field has been set.
  • restart should update this field as well.

Reference issue

Fixes #271

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #311 (14230ff) into master (302290a) will decrease coverage by 50.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #311       +/-   ##
===========================================
- Coverage   79.38%   28.79%   -50.60%     
===========================================
  Files          31       31               
  Lines        2295     2299        +4     
===========================================
- Hits         1822      662     -1160     
- Misses        335     1609     +1274     
+ Partials      138       28      -110
Flag Coverage Δ
go ?
wasm 28.79% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agent.go 0.00% <0.00%> (-82.07%) ⬇️
candidate_peer_reflexive.go 0.00% <0.00%> (-84.62%) ⬇️
agent_config.go 0.00% <0.00%> (-84.38%) ⬇️
transport.go 0.00% <0.00%> (-82.70%) ⬇️
agent_stats.go 0.00% <0.00%> (-82.36%) ⬇️
stun.go 0.00% <0.00%> (-75.00%) ⬇️
selection.go 0.00% <0.00%> (-74.63%) ⬇️
gather.go 0.00% <0.00%> (-70.39%) ⬇️
mdns.go 0.00% <0.00%> (-66.67%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302290a...14230ff. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only switch to failed after all candidates are exhausted?
1 participant
@scorpionknifes