From 85bd5d22f5035d3dacd30326db444c6b10a1834d Mon Sep 17 00:00:00 2001 From: Sean DuBois Date: Sun, 27 Oct 2024 23:29:52 -0400 Subject: [PATCH] Fix race when closing ICE Transport Struct member is copied to stack already, `stop` just incorrectly was referencing the member. Found in CI --- icetransport.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/icetransport.go b/icetransport.go index a86d4f94f1c..448929ca705 100644 --- a/icetransport.go +++ b/icetransport.go @@ -221,7 +221,7 @@ func (t *ICETransport) stop(shouldGracefullyClose bool) error { gatherer := t.gatherer t.lock.Unlock() - if t.mux != nil { + if mux != nil { var closeErrs []error if shouldGracefullyClose && gatherer != nil { // we can't access icegatherer/icetransport.Close via