Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FQDN ICE candidates #2300

Closed
i-sergienko opened this issue Sep 13, 2022 · 2 comments
Closed

Support FQDN ICE candidates #2300

i-sergienko opened this issue Sep 13, 2022 · 2 comments

Comments

@i-sergienko
Copy link

Summary

Add support for FQDN ICE candidates in addition to the already supported IP candidates.

Motivation

FQDN candidates are a valid option as per the RFC, and they are supported in other major WebRTC implementations (such as browser ones).
This feature will allow the users to use Pion to connect to peers that only expose FQDN candidates, which is somewhat tricky to achieve without direct library support.

Describe alternatives you've considered

A hypothetical alternative would be to post-process incoming ICE candidates, resolving any FQDNs to concrete IP addresses on the client side before passing them to the library. That adds implementation overhead to the user, and requires them to know the implementation details of the WebRTC stack instead of just using the library as a black box.

Additional context

@Sean-Der mentioned in the Slack channel that this feature has potential privacy implications.

@stv0g
Copy link
Member

stv0g commented Jan 12, 2023

@i-sergienko Can we close this issue here in favor of this one: pion/ice#512 ?

@i-sergienko
Copy link
Author

@stv0g Sounds good to me, closing it.

@i-sergienko i-sergienko closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants