Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation of NewPeerConnection #2949

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jech
Copy link
Member

@jech jech commented Nov 6, 2024

Please do not commit until @Sean-Der has had a chance to comment on 2943.

Fixes #2943

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.63%. Comparing base (363e017) to head (3ee0ee6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2949      +/-   ##
==========================================
- Coverage   77.74%   77.63%   -0.12%     
==========================================
  Files          89       89              
  Lines       10462    10462              
==========================================
- Hits         8134     8122      -12     
- Misses       1840     1850      +10     
- Partials      488      490       +2     
Flag Coverage Δ
go 79.19% <ø> (-0.13%) ⬇️
wasm 63.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jech jech force-pushed the document-newpeerconnection branch from 9989179 to 3ee0ee6 Compare November 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Pion spuriously negotiates transport-cc
1 participant