Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atmosphere of some planets appears as transparent sphere when seen from outside #6052

Open
MirceaKitsune opened this issue Feb 6, 2025 · 4 comments

Comments

@MirceaKitsune
Copy link

When approaching some planets, the atmopshere has a hard edge and appears as a transparent sphere when seen from the outside, it will appear normal once the ship enters it and it's seen from below. Attached two screenshots of the issue: First is the atmosphere seen before the ship is close, second is the correct result once the ship is inside the atmosphere.

Image
Image

Scattering is set to Rayleigh / MIE (accurate per-pixel), haven't checked if it also happens with Legacy. OS is Linux (Manjaro, KDE Plasma, Wayland) stock amdgpu driver, Pioneer compiled from latest Git master.

@bszlrd
Copy link
Contributor

bszlrd commented Feb 7, 2025

Image
(Sorry, couldn't resist :P)

@fluffyfreak
Copy link
Contributor

Unfortunately that is a pretty accurate representation of how our atmospheres work 🤣 minus the giant mecha-maid of course.

There's a shell of geometry that we render around each planet which has the atmosphere shader run on it

@fluffyfreak
Copy link
Contributor

Not that it doesn't maybe need tweaking of course. The actual function responsible for rendering the atmospheres is BaseSphere::DrawAtmosphereSurface, which is both hackier and uglier than I remember it being, I must be getting old.

@MirceaKitsune
Copy link
Author

MirceaKitsune commented Feb 8, 2025

The geometry shell makes sense: Virtually the volume is rendered inside a fixed sphere. The only issue seems to be that it doesn't fade to 0 alpha toward the outer edge when seen from the outside.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants