Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ORCID brand guidelines in ORCID functionality #10319

Open
2 tasks
ewhanson opened this issue Aug 14, 2024 · 2 comments
Open
2 tasks

Implement ORCID brand guidelines in ORCID functionality #10319

ewhanson opened this issue Aug 14, 2024 · 2 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@ewhanson
Copy link
Collaborator

Describe the issue
ORCID elements such as the "connect ORCID" button should conform to the ORCID branding guidelines as described in the ORCID documentation. There are mockups in Figma for the buttons under "ORCID verification". These currently appear in a few different places:

  • User profile (as noted in Figma)
  • In invitation emails (as noted in Figma). Email invitations should also include a plain-text link in addition to the email "button."
Screenshot of user profile mockup Screenshot of email invitation mockup

What application are you using?
OJS, OMP, and OPS version 3.5, (main branch)

@ewhanson ewhanson added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Aug 14, 2024
@ewhanson ewhanson added this to the 3.5.0 LTS milestone Aug 14, 2024
@taslangraham taslangraham self-assigned this Aug 22, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 28, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 4, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 4, 2024
taslangraham added a commit to taslangraham/ui-library that referenced this issue Sep 4, 2024
@taslangraham
Copy link
Contributor

Ready for review @ewhanson

PRs

pkp-lib

  1. Update email button to match ORCID guidelines; added plain text link; fix missing value for template variable, $principalContactSignature
    Screenshot 2024-09-04 121748

  2. Update ORCID buttons, and ID display on User profile page

    User's ORCID ID
    Screenshot 2024-09-04 124209

    User has ORCID but is currently not authenticated

    Screenshot 2024-09-04 124133

    User does not have ORCID

    Screenshot 2024-09-04 124047

  3. Added an automatic redirect with a message displayed on the page to inform the user after user successfully connects their ORCID record as advised by ORCID guidelines

UI Library
Display option to resend verification request as shown in Figma design
Screenshot 2024-09-04 125022

Submodule updates

@ewhanson
Copy link
Collaborator Author

Thanks @taslangraham! It's looking really good. Just a few questions in the PRs.

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 11, 2024
taslangraham added a commit to taslangraham/ui-library that referenced this issue Sep 12, 2024
taslangraham added a commit to taslangraham/ui-library that referenced this issue Sep 12, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
Status: Under Development
Development

No branches or pull requests

2 participants