Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OJS 3_4] submission Url not role dependant in discussion notification #10415

Open
forgive38 opened this issue Sep 13, 2024 · 1 comment · May be fixed by #10416
Open

[OJS 3_4] submission Url not role dependant in discussion notification #10415

forgive38 opened this issue Sep 13, 2024 · 1 comment · May be fixed by #10416

Comments

@forgive38
Copy link
Contributor

If a participant of a discussion has the author role, he should receive the url for authors, but he receives the url for "editors".
same case for discussions with reviewers.

I've tried to solve the problem by adding a param to Mailable, but I'm stuck.
I did a PR with a beginning but I'm not sure it's the right way to go...

I wonder if the simplest way wouldn't be to put a redirect in dispatcher for the main url “workflow/access/$submissionId”, depending on the current user's role: if he's only an author on the submission, we'll redirect him to authorDashboard and if he's only a reviewer, we'll redirect him to reviewer dashboard.

what do you think?

Thank you

@forgive38 forgive38 linked a pull request Sep 13, 2024 that will close this issue
@asmecher
Copy link
Member

@Vitaliy-1, could you look at this (and the associated PR)? Thanks, @forgive38!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants