Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue PDF galley page missing locale key submission.representationOfTitle #10559

Closed
NateWr opened this issue Oct 24, 2024 · 2 comments
Closed

Issue PDF galley page missing locale key submission.representationOfTitle #10559

NateWr opened this issue Oct 24, 2024 · 2 comments
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.3.0-20

Comments

@NateWr
Copy link
Contributor

NateWr commented Oct 24, 2024

Describe the bug
When an issue galley is displayed in the reader interface using pdfJsViewer, the iframe title attribute has a missing locale key:

<iframe
  title="##submission.representationOfTitle##"
  ...
>

To Reproduce
Steps to reproduce the behavior:

  1. Upload a PDF as an issue galley in Issues > (issue) > Issue Galleys.
  2. Publish the issue, view it in the reader interface, and click to view the galley.
  3. Inspect the source code to see the missing title attribute.

What application are you using?
OJS 3.3.x. I believe this only effects 3.3. If I remember correctly, from 3.4 we don't have to manually load locale files.

Additional information
PR coming in a second.
NateWr added a commit to NateWr/pdfJsViewer that referenced this issue Oct 24, 2024
@NateWr
pkp/pkp-lib#10559 Fix missing locale key in issue galleys
91f2513
@NateWr
Copy link
Contributor Author

NateWr commented Oct 24, 2024

PR:
pkp/pdfJsViewer#75

Tests:
pkp/ojs#4488

@NateWr
Copy link
Contributor Author

NateWr commented Nov 1, 2024

Just following up on this. It looks like the tests passed in all but one configuration, which looks unrelated.

jonasraoni added a commit to pkp/pdfJsViewer that referenced this issue Nov 11, 2024
@jonasraoni
Merge pull request #75 from NateWr/i10559_pdf_galley_locale_key
bfafb39 
pkp/pkp-lib#10559 Fix missing locale key in issue galleys
@jonasraoni jonasraoni added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Nov 11, 2024
@jonasraoni jonasraoni added this to the 3.3.0-20 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.3.0-20
Development

No branches or pull requests
2 participants
@jonasraoni @NateWr